Page MenuHomePhabricator

Revision links should not be hidden for non-admins in RevDelete delete log entries
Open, LowPublic



The links to "view diff | change visibility" in the delete log are only shown to those who can click through to view the diff (admins, oversighters).

There's a problem with hiding the diff links for non-admins, namely that in many cases the non-admin _can_ see some of all of the relevant diff, or may wish to know which diff it was even if they can't view the content. Non-linking means the end user cannot do so.

For example:

This delete log shows two revisions deleted. The user is not linked to them and cannot tell which two revisions are meant. But in fact if they were linked to the revision they could view some or all of it The fields they can't view will be greyed or struck out, or (for content) they will get a message saying they cannot view it.

Can we change RevDelete slightly so that the diff links are always shown?

The effect would be that anyone can identify which diffs are referenced (because link diffs are available) and click through from the log to the revision. Any fields they cannot see will either be greyed out, or they will get a message saying they cannot view the content or diff.

That seems a much more elegant way to do it.

Version: unspecified
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 11:03 PM
bzimport set Reference to bz22795.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Mar 10 2010, 4:59 PM
lfaraone lowered the priority of this task from Normal to Low.Sep 7 2015, 5:02 AM
lfaraone set Security to None.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2015, 5:02 AM
Restricted Application added a subscriber: JEumerus. · View Herald TranscriptAug 5 2016, 2:26 PM