Page MenuHomePhabricator

Add ThankYouScreen to App
Closed, ResolvedPublic


Show the ThankYouScreen after the save is done (instead of the DataBridge), and handle its button click event the same way as the “close” button (i. e., notify the init module that the window should be closed and the page reloaded).

This will probably involve at least updating some existing browser tests so they still work; consider making some of the click the “close” button and others click the “add/edit references” button to trigger the reload, so both alternatives are tested.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2020, 11:25 AM

Change 584576 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: WIP: bridge: wire up ThankYou

Pablo-WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-17 board.

Unassigning myself, I’m not really well suited to fix the browser tests (though I can try).

Claiming this again, since apparently I can run browser tests after all now, yay.

Change 584576 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: wire up ThankYou

Lucas_Werkmeister_WMDE closed this task as Resolved.Mar 31 2020, 6:08 PM