Page MenuHomePhabricator

wgNewUserMsgRevisionId (in JavaScript) is no longer set when the user has a new message
Closed, ResolvedPublic

Description

This is because of a typo in rMWe08e9609ffa0: OutputPage: Only export wgUserNewMsgRevisionId if non-null, which tries to export $$userNewMsgRevId instead of $userNewMsgRevId. This causes an undefined variable notice, which we don't seem to capture in logstash in production.

Event Timeline

Catrope created this task.Mar 19 2020, 3:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2020, 3:27 AM

Change 581241 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] OutputPage: Fix warning when setting wgUserNewMsgRevisionId

https://gerrit.wikimedia.org/r/581241

Change 581245 had a related patch set uploaded (by Krinkle; owner: Catrope):
[mediawiki/core@wmf/1.35.0-wmf.24] OutputPage: Fix warning when setting wgUserNewMsgRevisionId

https://gerrit.wikimedia.org/r/581245

Change 581241 merged by jenkins-bot:
[mediawiki/core@master] OutputPage: Fix warning when setting wgUserNewMsgRevisionId

https://gerrit.wikimedia.org/r/581241

zeljkofilipin triaged this task as Unbreak Now! priority.Mar 19 2020, 9:07 AM
zeljkofilipin added a subscriber: zeljkofilipin.

Train blockers are UBN.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMar 19 2020, 9:07 AM

Change 581245 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.24] OutputPage: Fix warning when setting wgUserNewMsgRevisionId

https://gerrit.wikimedia.org/r/581245

Mentioned in SAL (#wikimedia-operations) [2020-03-19T11:40:05Z] <lucaswerkmeister-wmde@deploy1001> Synchronized php-1.35.0-wmf.24/includes/OutputPage.php: SWAT: [[gerrit:581245|OutputPage: Fix warning when setting wgUserNewMsgRevisionId (T248049)]] (duration: 01m 08s)

Should be fixed now, though I was unable to produce a test case where that JS variable would be non-null during SWAT (I tried leaving myself a talk page message from another account but it didn’t seem to have any effect). Please verify :)

hashar closed this task as Resolved.Mar 19 2020, 1:09 PM
hashar assigned this task to Catrope.
hashar added a subscriber: hashar.

wgNewUserMsgRevisionId no more shows up in <head> on www.mediawiki.org. The double dollar sign fix has been deployed. That seems to be enough to justify it has been solved entirely.

Thanks for the deployment @Lucas_Werkmeister_WMDE