TimedMediaHandler has php deprecation warnings about unparenthesized expressions when running with php7.4
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Mar 19 2020, 4:57 PM

Description

14:23:05 Deprecated: The behavior of unparenthesized expressions containing both '.' and '+'/'-' will change in PHP 8: '+'/'-' will take a higher precedence in /workspace/src/extensions/TimedMediaHandler/includes/WebVideoTranscode/WebVideoTranscodeJob.php on line 422
14:23:05 PHP Deprecated:  The behavior of unparenthesized expressions containing both '.' and '+'/'-' will change in PHP 8: '+'/'-' will take a higher precedence in /workspace/src/extensions/TimedMediaHandler/includes/WebVideoTranscode/WebVideoTranscodeJob.php on line 422

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-docker/1508/console

			$cmd .= ' -t ' . intval( $options['endtime'] ) - intval( $options['starttime'] );

Details

	Subject	Repo	Branch	Lines +/-
	Fix for deprecated operator precedence thing in PHP 8	mediawiki/extensions/TimedMediaHandler	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned In: T248110: Create a sniff for: "PHP Deprecated: The behavior of unparenthesized expressions … will change in PHP 8"

Event Timeline

Umherirrender created this task.Mar 19 2020, 4:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2020, 4:57 PM

Umherirrender mentioned this in T248110: Create a sniff for: "PHP Deprecated: The behavior of unparenthesized expressions … will change in PHP 8".Mar 19 2020, 4:58 PM

• brion claimed this task.Mar 19 2020, 5:07 PM

Change 581663 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@master] Fix for deprecated operator precedence thing in PHP 8

https://gerrit.wikimedia.org/r/581663

gerritbot added a project: Patch-For-Review.Mar 19 2020, 5:18 PM

Change 581663 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Fix for deprecated operator precedence thing in PHP 8

https://gerrit.wikimedia.org/r/581663