Page MenuHomePhabricator
Create Task
Maniphest T248113

MultiMaps extension failing with Call to private Title::__construct() from context 'MultiMaps\BaseMapElement' \ 'MultiMaps\LeafletTest'
Closed, ResolvedPublic
Actions

Description

03:01:13 There were 9 errors:
03:01:13 
03:01:13 1) MultiMaps\LeafletTest::testParseOneMarkerTextOnly
03:01:13 === Logs generated by test case
03:01:13 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
03:01:13 [wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}
03:01:13 ===
03:01:13 Error: Call to private Title::__construct() from context 'MultiMaps\BaseMapElement'
03:01:13 
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:107
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/Marker.php:42
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:211
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:157
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:336
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:302
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:282
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:207
03:01:13 /workspace/src/extensions/MultiMaps/tests/phpunit/services/Leaflet/LeafletTest.php:61
03:01:13 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
03:01:13 /workspace/src/maintenance/doMaintenance.php:99
03:01:13 
03:01:13 2) MultiMaps\LeafletTest::testParseOneMarkerTitleOnly
03:01:13 === Logs generated by test case
03:01:13 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
03:01:13 [wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}
03:01:13 ===
03:01:13 Error: Call to private Title::__construct() from context 'MultiMaps\BaseMapElement'
03:01:13 
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:107
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/Marker.php:42
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:211
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:157
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:336
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:302
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:282
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:207
03:01:13 /workspace/src/extensions/MultiMaps/tests/phpunit/services/Leaflet/LeafletTest.php:77
03:01:13 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
03:01:13 /workspace/src/maintenance/doMaintenance.php:99
03:01:13 
03:01:13 3) MultiMaps\LeafletTest::testParseOneMarkerTitleText
03:01:13 === Logs generated by test case
03:01:13 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
03:01:13 [wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}
03:01:13 ===
03:01:13 Error: Call to private Title::__construct() from context 'MultiMaps\BaseMapElement'
03:01:13 
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:107
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/Marker.php:42
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:211
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:157
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:336
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:302
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:282
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:207
03:01:13 /workspace/src/extensions/MultiMaps/tests/phpunit/services/Leaflet/LeafletTest.php:93
03:01:13 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
03:01:13 /workspace/src/maintenance/doMaintenance.php:99
03:01:13 
03:01:13 4) MultiMaps\LeafletTest::testParseOneMarkerNamedTextOnly
03:01:13 === Logs generated by test case
03:01:13 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
03:01:13 [wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}
03:01:13 ===
03:01:13 Error: Call to private Title::__construct() from context 'MultiMaps\BaseMapElement'
03:01:13 
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:107
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/Marker.php:42
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:195
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:157
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:336
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:302
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:282
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:207
03:01:13 /workspace/src/extensions/MultiMaps/tests/phpunit/services/Leaflet/LeafletTest.php:110
03:01:13 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
03:01:13 /workspace/src/maintenance/doMaintenance.php:99
03:01:13 
03:01:13 5) MultiMaps\LeafletTest::testParseOneMarkerNamedTitleOnly
03:01:13 === Logs generated by test case
03:01:13 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
03:01:13 [wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}
03:01:13 ===
03:01:13 Error: Call to private Title::__construct() from context 'MultiMaps\BaseMapElement'
03:01:13 
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:107
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/Marker.php:42
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:195
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:157
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:336
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:302
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:282
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:207
03:01:13 /workspace/src/extensions/MultiMaps/tests/phpunit/services/Leaflet/LeafletTest.php:126
03:01:13 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
03:01:13 /workspace/src/maintenance/doMaintenance.php:99
03:01:13 
03:01:13 6) MultiMaps\LeafletTest::testParseOneMarkerNamedTextAndTile
03:01:13 === Logs generated by test case
03:01:13 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
03:01:13 [wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}
03:01:13 ===
03:01:13 Error: Call to private Title::__construct() from context 'MultiMaps\BaseMapElement'
03:01:13 
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:107
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/Marker.php:42
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:195
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:157
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:336
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:302
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:282
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:207
03:01:13 /workspace/src/extensions/MultiMaps/tests/phpunit/services/Leaflet/LeafletTest.php:142
03:01:13 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
03:01:13 /workspace/src/maintenance/doMaintenance.php:99
03:01:13 
03:01:13 7) MultiMaps\LeafletTest::testParseAllElementsWithProperties
03:01:13 === Logs generated by test case
03:01:13 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
03:01:13 [wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}
03:01:13 ===
03:01:13 Error: Call to private Title::__construct() from context 'MultiMaps\BaseMapElement'
03:01:13 
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:107
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/Marker.php:42
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:211
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:157
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:336
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:302
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:282
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:207
03:01:13 /workspace/src/extensions/MultiMaps/tests/phpunit/services/Leaflet/LeafletTest.php:337
03:01:13 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
03:01:13 /workspace/src/maintenance/doMaintenance.php:99
03:01:13 
03:01:13 8) MultiMaps\LeafletTest::testMessageElementMoreParameters
03:01:13 === Logs generated by test case
03:01:13 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
03:01:13 [wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}
03:01:13 ===
03:01:13 Error: Call to private Title::__construct() from context 'MultiMaps\BaseMapElement'
03:01:13 
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:107
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/Marker.php:42
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:211
03:01:13 /workspace/src/extensions/MultiMaps/includes/mapelements/BaseMapElement.php:157
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:336
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:302
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:282
03:01:13 /workspace/src/extensions/MultiMaps/includes/BaseMapService.php:207
03:01:13 /workspace/src/extensions/MultiMaps/tests/phpunit/services/Leaflet/LeafletTest.php:455
03:01:13 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
03:01:13 /workspace/src/maintenance/doMaintenance.php:99
03:01:13 
03:01:13 9) MultiMaps\LeafletTest::testParseWikitext
03:01:13 === Logs generated by test case
03:01:13 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
03:01:13 ===
03:01:13 Error: Call to private Title::__construct() from context 'MultiMaps\LeafletTest'
03:01:13 
03:01:13 /workspace/src/extensions/MultiMaps/tests/phpunit/services/Leaflet/LeafletTest.php:548
03:01:13 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
03:01:13 /workspace/src/maintenance/doMaintenance.php:99
03:01:13 
03:01:13 ERRORS!

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/54422/console

Details

SubjectRepoBranchLines +/-
Unbreak testsmediawiki/extensions/MultiMapsmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.Mar 19 2020, 5:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2020, 5:49 PM
DannyS712 added subscribers: Daimona, DannyS712.Mar 19 2020, 5:51 PM

Made private in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/577770/ as part of T247190: Complete TitleFactory to be a real factory service

DannyS712 added a parent task: T248116: Remove remaining calls to Title::__construct.Mar 19 2020, 5:55 PM
gerritbot added a comment.Mar 20 2020, 1:58 PM

Change 582029 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/MultiMaps@master] Unbreak tests

https://gerrit.wikimedia.org/r/582029

gerritbot added a project: Patch-For-Review.Mar 20 2020, 1:58 PM
Daimona claimed this task.Mar 20 2020, 2:01 PM
gerritbot added a comment.Mar 30 2020, 2:41 PM

Change 582029 merged by jenkins-bot:
[mediawiki/extensions/MultiMaps@master] Unbreak tests

https://gerrit.wikimedia.org/r/582029

Maintenance_bot removed a project: Patch-For-Review.Mar 30 2020, 3:10 PM
Daimona mentioned this in rEMMAcefb6a9d9a57: Unbreak tests.Mar 30 2020, 3:41 PM
Jdforrester-WMF closed this task as Resolved.Mar 30 2020, 6:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL