Page MenuHomePhabricator

Wikibase Travis CI jobs failing when wiki language is other than English
Closed, ResolvedPublic

Description

Looks like it is not Travis-specific, but some tests are generally not working for non-EN case.

Apparently got broken with merging https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/580369

First failing TravisCI build was: https://travis-ci.org/github/wikimedia/mediawiki-extensions-Wikibase/builds/664417187

For example failure from https://travis-ci.org/github/wikimedia/mediawiki-extensions-Wikibase/jobs/664417188

There was 1 failure:

1) Wikibase\Repo\Tests\Specials\SpecialMyLanguageFallbackChainTest::testExecute

=== Logs generated by test case

[objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}

[Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/localhost\/entity\/'"}

[wfDebug] [debug] IP: 127.0.0.1 {"private":false}

[MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}

[wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}

[Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"dataRightsUrl","logValue":"''"}

[Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"dataRightsText","logValue":"''"}

[GlobalTitleFail] [info] MessageCache::parse called with no title set. {"exception":{}}

[GlobalTitleFail] [info] MessageCache::parse called with no title set. {"exception":{}}

===

Cannot find 'ru - ' in the list of fallback languages in '<div class="mw-specialpage-summary">

<p>(mylanguagefallbackchain-summary)

</p>

</div><p>(wikibase-mylanguagefallbackchain-text)

</p><ul><li>qqx - </li><li>en - English</li></ul>'.

Failed asserting that false is of type "int".

/home/travis/build/wikimedia/phase3/extensions/Wikibase/repo/tests/phpunit/includes/Specials/SpecialMyLanguageFallbackChainTest.php:35

/home/travis/build/wikimedia/phase3/tests/phpunit/MediaWikiIntegrationTestCase.php:416

/home/travis/build/wikimedia/phase3/maintenance/doMaintenance.php:99

Event Timeline

Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald Transcript

Just investigating this now

Just to save some time. This is caused by these changed:

We are changing the default language of special pages in tests to qqx instead of the default (en) so 1- Tests would be faster 2- They stop depending on the value of the message that can change at any time. I don't know how it managed to break Travis though.

Change 582534 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Fix SpecialMyLanguageFallbackChainTest on non-English wikis

https://gerrit.wikimedia.org/r/582534

Change 582534 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix SpecialMyLanguageFallbackChainTest on non-English wikis

https://gerrit.wikimedia.org/r/582534