Page MenuHomePhabricator

Use revision and segment ID as input for synthesizing speech
Closed, ResolvedPublic

Description

The API should take revision id and segment id as input parameters instead of text. Before making the request to Speechoid, there should be a check that the revision has not been deleted. This has been prepared in T246084.

The needed changes in the storage.js:requestTts() is to send revision id and segment id to the WikispeechListen API instead of the text.

WikispeechListen need to be modified to first check that the revision is not deleted, then request the (already cached text) from the Wikispeech API (segmenter).

Event Timeline

Sebastian_Berlin-WMSE renamed this task from Use revision and segment id as input for synthesizing speech to Use revision and segment ID as input for synthesizing speech.Mar 31 2020, 10:08 AM

We need to talk a 15-30 min talk about this task to figure out and really document it. What we originally meant with it has somewhat been lost in time.

Lokal_Profil set the point value for this task to 20.May 14 2020, 9:18 AM

Probably makes sense to first do this as a patch (switch from sending text to sending rev_id and segement id) and add a @todo about RevDel. Then when that is merged rebase T246084: Add check for publically available revisions to handle that @todo

Is there any point in keeping text input as an alternative?

Is there any point in keeping text input as an alternative?

In the long run we might want to synthesize error messages or UI elements. So if possible keeping the functionality wouldn't be bad. Main question is how much it messes with UtteranceStore/caching

I have a kinda working solution now locally. I think there are still some tests that need to be added for coverage.

Since the frontend isn't aware of whether an utterance is new (not in cache) or not, the listen-API requires revision+segment and text. There may be more elegant ways of doing this, but this seems to work well enough for now.

The visibility of revisions (T246084) still needs to be added.

Sebastian_Berlin-WMSE changed the point value for this task from 20 to 8.Jul 23 2020, 8:46 AM

Change 616063 had a related patch set uploaded (by Sebastian Berlin (WMSE); owner: Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Add revision and segment id to listen API

https://gerrit.wikimedia.org/r/616063

Sebastian_Berlin-WMSE changed the point value for this task from 8 to 12.Aug 20 2020, 8:22 AM
Sebastian_Berlin-WMSE changed the point value for this task from 12 to 8.Aug 20 2020, 10:06 AM

Change 616063 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Add revision and segment id to listen API

https://gerrit.wikimedia.org/r/616063

Change 623782 had a related patch set uploaded (by Sebastian Berlin (WMSE); owner: Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Hotfix for 7418c2a

https://gerrit.wikimedia.org/r/623782

Change 623782 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Hotfix for 7418c2a

https://gerrit.wikimedia.org/r/623782

Lokal_Profil removed the point value for this task.Sep 3 2020, 8:11 AM