Page MenuHomePhabricator

Event schemas common schema should set additionalProperties: false
Closed, ResolvedPublic

Description

For some reason I thought this was already happening, but it isn't! We should make a new version of the common schema that sets additionalProperties: false. Specific schemas (like mediawiki/recentchange)can override this if they need to.

To do this we will make a new version of the common schema. I wouldn't bother updating the $refs to this new version until we need to actually make a change to existent schemas, but at least all new schemas (e.g. the upcoming eventlogging ones) will use the new common schema.

Event Timeline

Change 582028 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[schemas/event/primary@master] Set additionalProperties: false in fragment/common schema

https://gerrit.wikimedia.org/r/582028

Change 582028 merged by Ottomata:
[schemas/event/primary@master] Set additionalProperties: false in fragment/common schema

https://gerrit.wikimedia.org/r/582028

I created a new common schema version 1.1.0. Only mediawiki/client/error uses this ATM. If/when we create new versions for other schemas, we can upgrade their $ref of common to 1.1.0.