Page MenuHomePhabricator

Sniff for boolean/integer should not be case sensitive
Closed, ResolvedPublic

Description

Should also flag "Integer" and "Boolean" (currently doesn't)

Follow up to T145162
Discovered while updating documentation in T172836

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 582107 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/tools/codesniffer@master] Sniff for boolean/integer should not be case sensitive

https://gerrit.wikimedia.org/r/582107

This can have the same impact as Bool -> bool or Int -> int

In my opinion the change from case of the long type and the (already) short types should be done together (that's T172836)

Change 582107 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Sniff for boolean/integer should not be case sensitive

https://gerrit.wikimedia.org/r/582107