| Akinwale-microsoft | |
| Mar 20 2020, 9:54 PM |
| F31698151: 2020-03-22 19_45_19-Clipboard.png | |
| Mar 22 2020, 6:51 PM |
| F31698149: 2020-03-22 19_45_19-Clipboard.png | |
| Mar 22 2020, 6:51 PM |
Steps to Reproduce:
Actual Results:
"Close" button is not accessible through keyboard, while navigating using Tab key.
Expected Results:
"Close" button should be accessible through keyboard.
It's mapped directly through Esc and intentionally out of the taborder, IIRC. Is that wrong?
Change 582224 had a related patch set uploaded (by Akinwale-microsoft; owner: Akinwale-microsoft):
[oojs/ui@master] Making close button accessible by tab key
Note that this is a "Clear" button, not "Close", this is an important distinction to me.
I think you're thinking of different buttons though. As I understand it, this bug report is about this button on the "Upload" tab:
This button is indeed not accessible and this is definitely wrong.
I think @Jdforrester-WMF / @Volker_E are thinking of this button on the "Search" tab:
It is intentionally excluded from tab navigation, since it can easily be cleared using keyboard actions on the text field already, and we thought the additional tab stop would be confusing.
@Bkudiess-msft Coming from T255318, @Akinwale-microsoft has started this discussion a few weeks ago here.
SelectFileInputWidget inherits SearchInputWidget. Nonetheless it's not wishful from my current understanding, that we want to expose the clear functionality in search to keyboard users as the text gets auto-selected as soon as I tab to the input field and we would add a step to the taborder, slowing down keyboard users there.
From my keyboard accessibility understanding, and please share if you have other insights, I'd add the clear tab-ability only to SelectFileInput and not generally to SearchInput.
For completion,
Not only the "clear" button is not accessible by keyboard it also is missing a name and control type.
The following PR focuses on resolving all those issues:
https://gerrit.wikimedia.org/r/c/oojs/ui/+/605672
Change 605672 had a related patch set uploaded (by Bkudiess-msft; owner: Bkudiess-msft):
[oojs/ui@master] Makes search input widget indicator accessible
Change 582224 abandoned by Bartosz Dziewoński:
[oojs/ui@master] Making close button accessible by tab key
Reason:
Looks like https://gerrit.wikimedia.org/r/c/oojs/ui/ /605672 is an updated version of this patch
Change 605672 merged by jenkins-bot:
[oojs/ui@master] Make search input widget's "clear" indicator accessible
I made a small change to the patch before merging it, per @Volker_E's comments, so that in SearchInputWidget the "clear" button is focusable but not tabbable (tabindex="-1"). This way it isn't present in tab order on desktop, where the text can be easily cleared using keyboard shortcuts, but it can be activated e.g. on iOS with VoiceOver, where clearing a large text input field is a slow process. In SelectFileInputWidget it is tabbable, as it's the only way to clear the file selection.
For context, these are the two widgets (as used in VisualEditor):
| SelectFileInputWidget | SearchInputWidget |
|---|---|
| |
Thank you both for your patches @Bkudiess-msft @Akinwale-microsoft !
Change 611174 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.39.3