Page MenuHomePhabricator
Create Task
Maniphest T248257

Visual editor (and NWE) don't mark edits as minor
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  1. Edit an article in VisualEditor or VisualEditor-MediaWiki-2017WikitextEditor
  2. Save the edit as minor (tick "This edit is minor edit")

Actual Results:

  • The edit is not marked as minor.

Expected Results:

  • The edit is marked as minor.

Example (https://cs.wikipedia.org/w/index.php?title=V%C4%9Bty_o_shodnosti_troj%C3%BAheln%C3%ADku&diff=18299511&oldid=18297294&diffmode=source):

obrazek.png (368×500 px, 49 KB)
obrazek.png (25×1 px, 18 KB)
obrazek.png (23×1 px, 15 KB)

(no m for minor edit)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditorwmf/1.35.0-wmf.24+1 -1ApiVisualEditorEdit: Fix handling of 'minor' parameter
mediawiki/extensions/VisualEditormaster+1 -1ApiVisualEditorEdit: Fix handling of 'minor' parameter
Customize query in gerrit

Related Objects

Event Timeline

matej_suchanek created this task.Mar 22 2020, 11:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2020, 11:27 AM
matmarex added subscribers: Esanders, matmarex.Mar 22 2020, 6:39 PM

Must be a regression from rEVED50883dd7fea3: Don't pass through edit API params we've already handled, although I don't see immediately how it could happen.

matmarex claimed this task.Mar 23 2020, 4:29 PM
matmarex added a project: Editing-team (Q3 2019-2020 Kanban Board).
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
gerritbot added a comment.Mar 23 2020, 4:39 PM

Change 582841 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ApiVisualEditorEdit: Fix handling of 'minor' parameter

https://gerrit.wikimedia.org/r/582841

gerritbot added a project: Patch-For-Review.Mar 23 2020, 4:39 PM
matmarex moved this task from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.Mar 23 2020, 4:39 PM
gerritbot added a comment.Mar 23 2020, 5:03 PM

Change 582841 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ApiVisualEditorEdit: Fix handling of 'minor' parameter

https://gerrit.wikimedia.org/r/582841

Maintenance_bot removed a project: Patch-For-Review.Mar 23 2020, 5:10 PM
gerritbot added a comment.Mar 23 2020, 5:17 PM

Change 582857 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.24] ApiVisualEditorEdit: Fix handling of 'minor' parameter

https://gerrit.wikimedia.org/r/582857

gerritbot added a project: Patch-For-Review.Mar 23 2020, 5:17 PM
gerritbot added a comment.Mar 23 2020, 6:25 PM

Change 582857 merged by Urbanecm:
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.24] ApiVisualEditorEdit: Fix handling of 'minor' parameter

https://gerrit.wikimedia.org/r/582857

Stashbot added a comment.Mar 23 2020, 6:32 PM

Mentioned in SAL (#wikimedia-operations) [2020-03-23T18:32:04Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.24/extensions/VisualEditor/includes/ApiVisualEditorEdit.php: SWAT: rEVEDcbda0e55ed6c: ApiVisualEditorEdit: Fix handling of minor parameter (T248257) (duration: 01m 00s)

matmarex moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.Mar 23 2020, 6:40 PM
matmarex edited projects, added Editing QA; removed Patch-For-Review.

Should be fixed now (and deployed to all production wikis).

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 23 2020, 9:00 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Apr 9 2020, 11:37 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.
ppelberg closed this task as Resolved.Apr 11 2020, 12:30 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 11 2020, 12:30 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL