Page MenuHomePhabricator

Visual editor (and NWE) don't mark edits as minor
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  1. Edit an article in VisualEditor or VisualEditor-MediaWiki-2017WikitextEditor
  2. Save the edit as minor (tick "This edit is minor edit")

Actual Results:

  • The edit is not marked as minor.

Expected Results:

  • The edit is marked as minor.

Example (https://cs.wikipedia.org/w/index.php?title=V%C4%9Bty_o_shodnosti_troj%C3%BAheln%C3%ADku&diff=18299511&oldid=18297294&diffmode=source):

obrazek.png (368×500 px, 49 KB)
obrazek.png (25×1 px, 18 KB)
obrazek.png (23×1 px, 15 KB)

(no m for minor edit)

Event Timeline

Change 582841 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ApiVisualEditorEdit: Fix handling of 'minor' parameter

https://gerrit.wikimedia.org/r/582841

Change 582841 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ApiVisualEditorEdit: Fix handling of 'minor' parameter

https://gerrit.wikimedia.org/r/582841

Change 582857 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.24] ApiVisualEditorEdit: Fix handling of 'minor' parameter

https://gerrit.wikimedia.org/r/582857

Change 582857 merged by Urbanecm:
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.24] ApiVisualEditorEdit: Fix handling of 'minor' parameter

https://gerrit.wikimedia.org/r/582857

Mentioned in SAL (#wikimedia-operations) [2020-03-23T18:32:04Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.24/extensions/VisualEditor/includes/ApiVisualEditorEdit.php: SWAT: cbda0e5: ApiVisualEditorEdit: Fix handling of minor parameter (T248257) (duration: 01m 00s)

matmarex edited projects, added Editing QA; removed Patch-For-Review.

Should be fixed now (and deployed to all production wikis).