Page MenuHomePhabricator
Create Task
Maniphest T248266

getFileVersionHistoryTable does not work corectly
Closed, ResolvedPublic
Actions

Description

getFileVersionHistoryTable return error when I tried to create history table

TypeError

format() argument after ** must be a mapping, not Timestamp

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
component: pywikibot-corepywikibot/coremaster+4 -3
component: pywikibot-corepywikibot/coremaster+3 -2
Customize query in gerrit

Related Objects

Event Timeline

RLuts created this task.Mar 22 2020, 5:42 PM
Restricted Application added subscribers: pywikibot-bugs-list, Base, Aklapper. · View Herald TranscriptMar 22 2020, 5:42 PM
gerritbot added a comment.Mar 22 2020, 6:11 PM

Change 582588 had a related patch set uploaded (by RLuts; owner: RLuts):
[pywikibot/core@master] component: pywikibot-core

https://gerrit.wikimedia.org/r/582588

gerritbot added a project: Patch-For-Review.Mar 22 2020, 6:11 PM
RLuts claimed this task.Mar 22 2020, 6:12 PM
gerritbot added a comment.Mar 22 2020, 6:38 PM

Change 582589 had a related patch set uploaded (by RLuts; owner: RLuts):
[pywikibot/core@master] component: pywikibot-core

https://gerrit.wikimedia.org/r/582589

Dvorapa subscribed.EditedMar 22 2020, 6:51 PM

Hi, you created two pull requests, please keep Change-Id in commit message and never push more than one commit (use git commit --amend). Please merge both patches together

gerritbot added a comment.Mar 22 2020, 7:25 PM

Change 582589 abandoned by RLuts:
component: pywikibot-core

Reason:
duplicate pull request

https://gerrit.wikimedia.org/r/582589

RLuts added a comment.Mar 22 2020, 7:26 PM
In T248266#5990263, @Dvorapa wrote:

Hi, you created two pull requests, please keep Change-Id in commit message and never push more than one commit (use git commit --amend). Please merge both patches together

Thanks for helping. Updated

gerritbot added a comment.Mar 22 2020, 7:42 PM

Change 582588 merged by jenkins-bot:
[pywikibot/core@master] component: pywikibot-core

https://gerrit.wikimedia.org/r/582588

RLuts mentioned this in rPWBC1ae58b56b348: component: pywikibot-core.Mar 22 2020, 7:51 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 22 2020, 8:10 PM
Dvorapa closed this task as Resolved.Mar 22 2020, 10:09 PM

Nice catch and thank you for your fix :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits