Page MenuHomePhabricator

Structured Data on Commons: RTL support for negative numbers
Closed, ResolvedPublic

Description

Found while checking T242627.

Steps to reproduce:

  1. View a file with structured data with your UI set to a RTL language (e.g. https://commons.wikimedia.org/wiki/File:Malibu-superbloom.jpg?uselang=he)
  2. Click 'Edit' and ' Add qualifier'
  3. Type a negative number and observe that a negative sign will be entered as RTL. in hewiki negative numbers, e.g. for some temperature measurements, are entered with weak directionality:

Screen Shot 2020-03-23 at 6.01.11 PM.png (114×859 px, 51 KB)

The negative numbers entered in the following element

<div class="wbmi-input-widget__input oo-ui-widget oo-ui-inputWidget oo-ui-textInputWidget oo-ui-textInputWidget-type-number oo-ui-widget-enabled" aria-disabled="false"><input step="any" type="number" tabindex="0" aria-disabled="false" class="oo-ui-inputWidget-input" value=""><span class="oo-ui-iconElement-icon oo-ui-iconElement-noIcon"></span><span class="oo-ui-indicatorElement-indicator oo-ui-indicatorElement-noIndicator"></span></div>

will be displayed and saved incorrectly:

Screen Shot 2020-03-23 at 7.37.30 PM.png (234×803 px, 24 KB)

Screen Shot 2020-03-23 at 6.15.32 PM.png (303×890 px, 37 KB)

Event Timeline

Etonkovidova claimed this task.

Re-checked it with patches that were done for T246797: Structured Data on Commons: RTL support for geographical co-ordinates - the issue seems to be fixed:

Screen Shot 2020-04-01 at 4.59.00 PM.png (459×830 px, 58 KB)

Marking this task as Resolved and adding it to list of tasks to be checked after deployment.