Page MenuHomePhabricator
Create Task
Maniphest T248392

Remove support for null $action in Action::factory
Closed, ResolvedPublic
Actions

Description

Calling Action::factory with null was hard-deprecated in 1.35. Support for it should be removed.

Details

SubjectRepoBranchLines +/-
Hard deprecate Action::factory with null argument $actionmediawiki/coremaster+43 -20
Fix type doc of ActionTestCase::createAction()mediawiki/extensions/Wikibasemaster+5 -5
Customize query in gerrit

Event Timeline

Art-Baltai created this task.Mar 24 2020, 2:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2020, 2:38 PM
Aklapper added a project: MediaWiki-General.Mar 25 2020, 10:23 AM
Peter.ovchyn moved this task from In Progress/Doing to Backlog on the Platform Team Workboards (S&F Workboard) board.Mar 31 2020, 3:46 PM
gerritbot added a comment.Apr 1 2020, 4:19 AM

Change 585063 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/extensions/Wikibase@master] Action::factory() and ActionTestCase::createAction() $action must be string

https://gerrit.wikimedia.org/r/585063

gerritbot added a project: Patch-For-Review.Apr 1 2020, 4:19 AM

Change 585064 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/core@master] Action::factory $action argument not nullable

https://gerrit.wikimedia.org/r/585064

Art-Baltai moved this task from Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Apr 2 2020, 4:00 PM
Art-Baltai moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.
gerritbot added a comment.Apr 9 2020, 9:58 AM

Change 585063 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix type doc of ActionTestCase::createAction()

https://gerrit.wikimedia.org/r/585063

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 9 2020, 10:00 AM
• Pchelolo renamed this task from Action::factory $action must not be nullable to Remove support for null $action in Action::factory.Apr 11 2020, 3:49 AM
• Pchelolo edited projects, added Technical-Debt (Deprecation process); removed Patch-For-Review.
• Pchelolo updated the task description. (Show Details)
• Pchelolo moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
gerritbot added a comment.Apr 11 2020, 4:07 AM

Change 585064 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Action::factory with null argument $action

https://gerrit.wikimedia.org/r/585064

Peter.ovchyn moved this task from In Progress/In Review to Done on the Platform Team Workboards (S&F Workboard) board.Apr 16 2020, 9:26 AM
Peter.ovchyn closed this task as Resolved.May 7 2020, 3:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL