Page MenuHomePhabricator

Refactor WritingEntityRepository to accept Entity + EntityRevision
Closed, ResolvedPublic

Description

Currently, WritingEntityRepository accepts a single EntityRevision, containing the new entity data and the base revision ID. Make it accept an Entity and an EntityRevision instead, where the Entity contains the new entity data and the EntityRevision contains the base revision data + ID. This will allow us to introduce a new layer which diffs the old against the new data and removes parts that didn’t change and therefore don’t need to be sent over the wire.

This also resolves the conceptual smell that the current input EntityRevision doesn’t really represent any particular revision at all – its revision ID does not match its entity data.

Event Timeline

Change 584019 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: make WritingEntityRepository take Entity + Revision

https://gerrit.wikimedia.org/r/584019

Change 584019 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: make WritingEntityRepository take Entity + Revision

https://gerrit.wikimedia.org/r/584019