⚓ T248490 Move scap plugins from mediawiki-config repo to scap repo

Subject	Repo	Branch	Lines +/-
fix: find plugins again	mediawiki/tools/scap	master	+115 -1
Drop scap plugins, moved into scap proper	operations/mediawiki-config	master	+0 -1 K
Move scap plugins from mediawiki-config into this repo	mediawiki/tools/scap	master	+1 K -0

		Status	Subtype	Assigned	Task
		Resolved		Jdforrester-WMF	T248040 Scap plugins in operations/mediawiki-config don't pass tox, so CI is disabled
		Resolved		• LarsWirzenius	T248490 Move scap plugins from mediawiki-config repo to scap repo

Jdforrester-WMF created this task.Mar 25 2020, 5:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2020, 5:16 PM

Jdforrester-WMF moved this task from INBOX to Maintenance on the Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)) board.Mar 25 2020, 5:46 PM

Jdforrester-WMF added a parent task: T248040: Scap plugins in operations/mediawiki-config don't pass tox, so CI is disabled.Mar 25 2020, 5:49 PM

thcipriani assigned this task to • LarsWirzenius.Apr 8 2020, 5:59 PM

thcipriani triaged this task as Medium priority.

Change 599973 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/tools/scap@master] Move scap plugins from mediawiki-config into this repo

https://gerrit.wikimedia.org/r/599973

gerritbot added a project: Patch-For-Review.May 29 2020, 7:40 PM

Change 599973 merged by jenkins-bot:
[mediawiki/tools/scap@master] Move scap plugins from mediawiki-config into this repo

https://gerrit.wikimedia.org/r/599973

Maintenance_bot removed a project: Patch-For-Review.Jun 1 2020, 1:10 PM

Change 601388 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Drop scap plugins, moved into scap proper

https://gerrit.wikimedia.org/r/601388

gerritbot added a project: Patch-For-Review.Jun 1 2020, 6:48 PM

thcipriani edited projects, added: Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)); removed: Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)).Jul 8 2020, 5:34 PM

• LarsWirzenius removed • LarsWirzenius as the assignee of this task.Aug 13 2020, 1:48 PM

• LarsWirzenius subscribed.

Change 601388 merged by jenkins-bot:
[operations/mediawiki-config@master] Drop scap plugins, moved into scap proper

https://gerrit.wikimedia.org/r/601388

Maintenance_bot removed a project: Patch-For-Review.Sep 30 2020, 3:10 PM

Jdforrester-WMF closed this task as Resolved.Sep 30 2020, 4:37 PM

Jdforrester-WMF claimed this task.

rOMWC658f28991a78 broke deployments. scap update-wikiversions was removed and apparently it's not in scap core.

In T248490#6506469, @mmodell wrote:

rOMWC658f28991a78 broke deployments. scap update-wikiversions was removed and apparently it's not in scap core.

It was added in https://gerrit.wikimedia.org/r/c/mediawiki/tools/scap/+/599973/1/scap/plugins/updatewikiversions.py surely?

missing on deploy1001 .. did the new version actually get rolled out to all of production?

Not sure. @LarsWirzenius?

~~~sh
liw@deploy1001:~$ scap version
3.15.0-1
liw@deploy1001:~$ dpkg -L scap | grep wikiversions
/usr/lib/python2.7/dist-packages/scap/plugins/updatewikiversions.py
liw@deploy1001:~$
~~~

The plugin is in the version on deploy1001, but Scap doesn't find it. I did not notice this when adding the plugins to Scap. I'll figure out what the problem is and submit a fix.

This is what I get for touching software that lacks test suites, I guess. Sorry.

Reverted as scap lost track of (some of?) the plugins.

Jdforrester-WMF reassigned this task from Jdforrester-WMF to • LarsWirzenius.Oct 1 2020, 4:50 PM

• LarsWirzenius edited projects, added: Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)); removed: Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)).Oct 5 2020, 1:42 PM

• LarsWirzenius moved this task from INBOX to Maintenance on the Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)) board.Oct 7 2020, 2:26 PM

Change 633205 had a related patch set uploaded (by Lars Wirzenius; owner: Lars Wirzenius):
[mediawiki/tools/scap@master] fix: find plugins again

https://gerrit.wikimedia.org/r/633205

gerritbot added a project: Patch-For-Review.Oct 9 2020, 4:13 PM

Change 633205 merged by jenkins-bot:
[mediawiki/tools/scap@master] fix: find plugins again

https://gerrit.wikimedia.org/r/633205

• mmodell awarded a token.Oct 13 2020, 3:56 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 13 2020, 4:10 PM

• LarsWirzenius mentioned this in T268634: Deploy Scap version 3.16.0-1.Dec 8 2020, 4:04 PM

Done earlier this week.

Move scap plugins from mediawiki-config repo to scap repo
Closed, ResolvedPublic
Actions

Description

Details

Revisions and Commits

Related Objects
Search...

Event Timeline

rOMWC Wikimedia - MediaWiki Config
	Concern Raised	rOMWC658f28991a78 Drop scap plugins, moved into scap proper

Move scap plugins from mediawiki-config repo to scap repoClosed, ResolvedPublicActions