Page MenuHomePhabricator
Create Task
Maniphest T248509

Remove deprecated ways to call WikiPage::doDeleteArticleReal
Closed, ResolvedPublic
Actions

Description

3 methods that proxy it, all hard deprecated in 1.35, to be removed:

  • WikiPage::doDeleteArticle
  • Article::doDeleteArticle
  • Article::doDeleteArticleReal

Old signature, hard deprecated in 1.35, to be removed

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+24 -115Remove deprecated ways to call WikiPage::doDeleteArticleReal
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 changed the task status from Open to Stalled.Mar 25 2020, 8:10 PM
DannyS712 triaged this task as Medium priority.
DannyS712 created this task.
DannyS712 added a parent task: T239975: Complete WikiPage/Article split and deprecate Page interface.
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

Cannot be removed until 1.36

DannyS712 added subscribers: Hexmode, JeroenDeDauw, MarkAHershberger.Mar 25 2020, 8:12 PM

Heads up: some github repos need to be updated:

DannyS712 renamed this task from Remove deprecated proxies for WikiPage::doDeleteArticleReal to Remove deprecated ways to call WikiPage::doDeleteArticleReal.Mar 31 2020, 4:12 AM
DannyS712 updated the task description. (Show Details)
DannyS712 moved this task from Next to Later on the User-DannyS712 board.Apr 13 2020, 9:14 PM
Art-Baltai added a subscriber: Art-Baltai.May 21 2020, 1:15 PM

This task looks as not actual

DannyS712 added a comment.May 21 2020, 5:08 PM
In T248509#6155270, @Art-Baltai wrote:

This task looks as not actual

I'm afraid I'm not sure what you mean

DannyS712 changed the task status from Stalled to Open.Jul 14 2020, 9:51 AM
gerritbot added a comment.Sep 10 2020, 4:56 PM

Change 626427 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove deprecated ways to call WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/626427

gerritbot added a project: Patch-For-Review.Sep 10 2020, 4:56 PM
DannyS712 moved this task from Later to Awaiting review and deployment on the User-DannyS712 board.Sep 10 2020, 5:06 PM
DannyS712 added a project: Platform Team Workboards (External Code Reviews).
Izno added a subscriber: Izno.Sep 10 2020, 6:38 PM
In T248509#6451308, @gerritbot wrote:

Change 626427 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove deprecated ways to call WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/626427

Just a minor catch that has been there a while, but

  • Multiple methods previously had optional User parameters, with fallbacks

to the $wgUser global variable. Not passing a User to those methods was
previously hard deprecated, and support for now passing a User has now
been removed:

has a line:

and support for nownot passing a User has now
been removed:

with a typo.

DannyS712 added a comment.EditedSep 10 2020, 6:39 PM
In T248509#6451613, @Izno wrote:
In T248509#6451308, @gerritbot wrote:

Change 626427 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove deprecated ways to call WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/626427

Just a minor catch that has been there a while, but

  • Multiple methods previously had optional User parameters, with fallbacks

to the $wgUser global variable. Not passing a User to those methods was
previously hard deprecated, and support for now passing a User has now
been removed:

has a line:

and support for nownot passing a User has now
been removed:

with a typo.

{{done}}

gerritbot added a comment.Sep 10 2020, 7:29 PM

Change 626427 merged by jenkins-bot:
[mediawiki/core@master] Remove deprecated ways to call WikiPage::doDeleteArticleReal

https://gerrit.wikimedia.org/r/626427

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 10 2020, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 10 2020, 8:11 PM
DannyS712 closed this task as Resolved.Sep 10 2020, 9:17 PM
Nikerabbit added a subscriber: Nikerabbit.Sep 14 2020, 8:45 AM

This caused T262800: [Merge blocker] mwext-php72-phan-docker: Argument 2 ($deleter) is false of type false but \WikiPage::doDeleteArticleReal() takes \User

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL