Create UserOptionsManager
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pchelolo
	Mar 25 2020, 10:50 PM

Description

User options management should be pulled out of the User class and converted into a mediawiki service.

Details

Subject	Repo	Branch	Lines +/-
Inject UserOptionsLookup into GenderCache	mediawiki/core	master	+16 -4
UserOptionsManager: take into account $queryFlags when caching	mediawiki/core	master	+100 -19
Introduce UserOptionsManager and DefaultOptionsManager	mediawiki/core	master	+1 K -406

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T223099 Factor code for handling for options (preferences) out of User class
		Resolved		• Pchelolo	T248527 Create UserOptionsManager

Event Timeline

• Pchelolo created this task.Mar 25 2020, 10:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2020, 10:50 PM

Change 565462 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Introduce UserOptionsManager and DefaultOptionsManager

https://gerrit.wikimedia.org/r/565462

gerritbot added a project: Patch-For-Review.Mar 25 2020, 10:51 PM

• Pchelolo added a project: Platform Team Workboards (Clinic Duty Team).Mar 25 2020, 10:53 PM

• Pchelolo moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.

DannyS712 awarded a token.Mar 25 2020, 10:56 PM

DannyS712 subscribed.

Merge with T223099: Factor code for handling for options (preferences) out of User class ?

• Pchelolo added a parent task: T223099: Factor code for handling for options (preferences) out of User class.Mar 27 2020, 3:35 PM

daniel triaged this task as Medium priority.Apr 7 2020, 12:51 PM

Change 565462 merged by jenkins-bot:
[mediawiki/core@master] Introduce UserOptionsManager and DefaultOptionsManager

https://gerrit.wikimedia.org/r/565462

Change 593818 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Inject UserOptionsLookup into GenderCache

https://gerrit.wikimedia.org/r/593818

• Pchelolo moved this task from Waiting for Review to Ready (WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.May 12 2020, 2:08 PM

Catrope mentioned this in T253149: Regression: UserSaveOptions hook no longer exposes old preference values.May 19 2020, 7:32 PM

This caused a regression that broke several extensions: T253149: Regression: UserSaveOptions hook no longer exposes old preference values

Change 599403 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] UserOptionsManager: take into account $queryFlags when caching

https://gerrit.wikimedia.org/r/599403

Change 599403 merged by jenkins-bot:
[mediawiki/core@master] UserOptionsManager: take into account $queryFlags when caching

https://gerrit.wikimedia.org/r/599403