Page MenuHomePhabricator

CU 2.0: Update Special:InvestigateBlock to add new options
Closed, ResolvedPublic3 Estimated Story PointsJun 30 2020

Description

Goal

Existing Checkuser blocking feature includes some options that are not in the standard Special:Block form. We should include them in the Special:Investigate block that we are adding in T248528: CU 2.0: Blocking - add new Special:InvestigateBlock .

Acceptance criteria
  • Under Additional options on Special:Investigate block, add the following options:

Mobile Copy.png (386×350 px, 20 KB)

    • Three options should be in each dropdown: Prepend, Append, Replace
    • Default option for User pages should be Prepend
    • Default option for User talk should be Append
    • Field should be disabled till the checkbox is clicked
    • Replace talk pages with: - will replace the users' talk pages with the wikitext supplied in the textarea
    • Replace user pages with: - will replace the users' user pages with the wikitext supplied in the textarea
  • Allow reblocking users per T249562: Checkuser should allow reblocking users and tag pages even if users are already blocked

Event Timeline

Niharika triaged this task as Medium priority.Mar 25 2020, 11:47 PM
Niharika created this task.
ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".

@Prtksxna After adding these fields, the page looks quite busy. Should we split it into sections, to look more like Special:Block?

No sectionsSections
image.png (681×739 px, 30 KB)
image.png (761×794 px, 35 KB)

@Prtksxna After adding these fields, the page looks quite busy. Should we split it into sections, to look more like Special:Block?

Adding those sections is definitely a good idea. But I am a bit confused about this page, aren't we going to have partial blocking options here? Like in M255?

From the description:

Under Additional options on Special:Investigate block, add the following options:

I was under the impression that we could add it under that heading ☝🏽 (M255 again).

Thanks @Prtksxna. I'll move the tag pages options to a new "Additional options" section - thanks for pointing that out.

We decided in T248528 to go with the limited form - i.e. copying the form that currently exists in Special:CheckUser. (That was after the investigation about how we could implement something more like the full Special:Block form.)

Special:CheckUser has quite a few differences from Special:Block, including not allowing partial blocks, not being able to specify the block expiry, having a limited text input for the Reason, etc. (I've suggested getting user feedback on some of those things - T248528#6244118.)

Change 607124 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] SpecialInvestigateBlock: Add options to tag pages of blocked users

https://gerrit.wikimedia.org/r/607124

Change 607124 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] SpecialInvestigateBlock: Add options to tag pages of blocked users

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/ /607124

dom_walden added a subscriber: dom_walden.

I tested blocking and reblocking a number of different users and IPs, checking that it appended, prepended or replaced the appropriate User/User_talk (including for IPs).

I tested a few different types of wikitext, including links and templates. I could not get wikitext tables working (I am not sure if it is possible).

I can also enter blank text input to blank a User/User_talk page.

Test environment: local vagrant, MediaWiki 1.35.0-alpha (39688e3)