Page MenuHomePhabricator
Create Task
Maniphest T248549

Remove Revision::getRevisionText
Closed, ResolvedPublic
Actions

Description

Hard deprecated

Remaining uses:

Details

SubjectRepoBranchLines +/-
Make MathSearch compatible to MW 1.35mediawiki/extensions/MathSearchmaster+30 -20
Declare extension incompatible with MediaWiki 1.35mediawiki/extensions/MessageCommonsmaster+3 -0
Declare extension incompatible with MediaWiki 1.35mediawiki/extensions/MathSearchmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 changed the task status from Open to Stalled.Mar 26 2020, 4:32 AM
DannyS712 triaged this task as Medium priority.
DannyS712 created this task.
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.

Cannot be removed until 1.36

DannyS712 added a parent task: T247143: Remove the Revision class [1.37].Mar 26 2020, 4:33 AM
This comment was removed by DannyS712.
gerritbot added a comment.Mar 31 2020, 3:07 AM

Change 584788 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MathSearch@master] Remove use of Revision::getRevisionText

https://gerrit.wikimedia.org/r/584788

gerritbot added a project: Patch-For-Review.Mar 31 2020, 3:07 AM
DannyS712 added a comment.Mar 31 2020, 3:11 AM
In T248549#6013190, @gerritbot wrote:

Change 584788 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MathSearch@master] Remove use of Revision::getRevisionText

https://gerrit.wikimedia.org/r/584788

Please note that this patch actually declares the extension incompatible with 1.35+, because the current code results in LogicExceptions being thrown

gerritbot added a comment.Mar 31 2020, 3:19 AM

Change 584792 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MessageCommons@master] Declare extension incompatible with MediaWiki 1.35

https://gerrit.wikimedia.org/r/584792

gerritbot added a comment.Mar 31 2020, 7:02 AM

Change 584788 merged by jenkins-bot:
[mediawiki/extensions/MathSearch@master] Declare extension incompatible with MediaWiki 1.35

https://gerrit.wikimedia.org/r/584788

DannyS712 updated the task description. (Show Details)Mar 31 2020, 7:15 AM
DannyS712 mentioned this in rEMAS5760f09ecdd0: Declare extension incompatible with MediaWiki 1.35.Mar 31 2020, 8:05 AM
DannyS712 mentioned this in T247143: Remove the Revision class [1.37].Apr 3 2020, 9:52 PM
Physikerwelt mentioned this in T249414: Make MathSearch 1.35 compatible.Apr 4 2020, 11:49 AM
gerritbot added a comment.Apr 4 2020, 6:24 PM

Change 585960 had a related patch set uploaded (by Physikerwelt; owner: Physikerwelt):
[mediawiki/extensions/MathSearch@master] Make MathSearch compatible to MW 1.35

https://gerrit.wikimedia.org/r/585960

gerritbot added a comment.Apr 4 2020, 6:28 PM

Change 585960 merged by jenkins-bot:
[mediawiki/extensions/MathSearch@master] Make MathSearch compatible to MW 1.35

https://gerrit.wikimedia.org/r/585960

Physikerwelt mentioned this in rEMAS18ab9bfdfb46: Make MathSearch compatible to MW 1.35.Apr 4 2020, 6:46 PM
Physikerwelt updated the task description. (Show Details)Apr 5 2020, 5:26 AM
DannyS712 moved this task from Next to Later on the User-DannyS712 board.Apr 13 2020, 9:14 PM
DannyS712 edited projects, added MediaWiki-Core-Revision-backend; removed MediaWiki-General.Apr 27 2020, 6:09 AM
gerritbot added a comment.May 31 2020, 12:43 AM

Change 584792 abandoned by DannyS712:
Declare extension incompatible with MediaWiki 1.35

Reason:
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MessageCommons/ /525078/ was merged, no longer needed

https://gerrit.wikimedia.org/r/584792

DannyS712 removed a project: Patch-For-Review.May 31 2020, 12:43 AM
DannyS712 updated the task description. (Show Details)
DannyS712 changed the task status from Stalled to Open.Jul 14 2020, 9:50 AM
DannyS712 removed a parent task: T245331: Remove core fallbacks to global $wgUser [1.36].Nov 30 2020, 10:51 PM
DannyS712 moved this task from 2020 | MW 1.35 to Not yet on the Technical-Debt (Deprecation process) board.Dec 18 2020, 2:18 AM
taavi subscribed.Dec 29 2020, 2:43 PM

This has some uses in Translate, one of them has a comment saying Should only happen with MW < 1.34.

DannyS712 changed the task status from Open to Stalled.Dec 29 2020, 9:01 PM

Reflect decision to wait until 1.37 for Revision removals

DannyS712 added a comment.Dec 29 2020, 9:03 PM
In T248549#6713735, @Majavah wrote:

This has some uses in Translate, one of them has a comment saying Should only happen with MW < 1.34.

Translate maintains compatibility with non-MASTER versions of core, and so has some backwards-compatibility code - if it should only be run with MW < 1.34, then it doesn't matter if we remove the code in a later version

DannyS712 closed this task as Resolved.Jun 10 2021, 10:53 PM

This task was filed when I was not expecting to be able to remove the whole Revision class, sorry for the confusion. Resolving now that the entire class has been removed as part of T247143, see rMW983984d5d4a4: EPIC: Remove the Revision class entirely.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL