Page MenuHomePhabricator
Create Task
Maniphest T248550

Math extension needs uses of global $wgUser removed
Closed, ResolvedPublic
Actions

Description

See parent task for reasoning

Codesearch for use of $wgUser: https://codesearch.wmflabs.org/search/?q=%5C%24wgUser&i=nope&files=&repos=Extension:Math

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
MathGenerateTests: Remove use of $wgUsermediawiki/extensions/Mathmaster+1 -2
Remove use of $wgUser in onMaintenanceRefreshLinksInitmediawiki/extensions/Mathmaster+2 -2
Remove fallback to $wgUser in MathHooks::onPageRenderingHashmediawiki/extensions/Mathmaster+4 -8
Remove unused non-global $wgUser in wfTestmediawiki/extensions/Mathmaster+0 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Mar 26 2020, 6:03 AM
DannyS712 triaged this task as Medium priority.
Restricted Application added a project: User-DannyS712. · View Herald TranscriptMar 26 2020, 6:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Mar 26 2020, 6:03 AM
gerritbot added a comment.Sep 11 2020, 6:33 PM

Change 626675 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Math@master] Remove unused non-global $wgUser

https://gerrit.wikimedia.org/r/626675

gerritbot added a project: Patch-For-Review.Sep 11 2020, 6:33 PM
DannyS712 added a project: Platform Team Workboards (External Code Reviews).Sep 11 2020, 6:34 PM
gerritbot added a comment.Sep 11 2020, 6:55 PM

Change 626675 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Remove unused non-global $wgUser in wfTest

https://gerrit.wikimedia.org/r/626675

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 11 2020, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 11 2020, 7:10 PM
DannyS712 mentioned this in T159299: Deprecate and remove $wgUser.Sep 11 2020, 7:13 PM
gerritbot added a comment.Sep 21 2020, 9:20 PM

Change 628823 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Math@master] Remove fallback to $wgUser in MathHooks::onPageRenderingHash

https://gerrit.wikimedia.org/r/628823

gerritbot added a project: Patch-For-Review.Sep 21 2020, 9:20 PM
gerritbot added a comment.Sep 24 2020, 3:41 PM

Change 628823 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Remove fallback to $wgUser in MathHooks::onPageRenderingHash

https://gerrit.wikimedia.org/r/628823

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.11; 2020-09-29); removed MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 24 2020, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 24 2020, 4:10 PM
gerritbot added a comment.Sep 27 2020, 1:02 AM

Change 630238 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Math@master] Remove use of $wgUser in onMaintenanceRefreshLinksInit

https://gerrit.wikimedia.org/r/630238

gerritbot added a project: Patch-For-Review.Sep 27 2020, 1:02 AM
gerritbot added a comment.Sep 27 2020, 4:12 PM

Change 630238 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Remove use of $wgUser in onMaintenanceRefreshLinksInit

https://gerrit.wikimedia.org/r/630238

DannyS712 removed a subtask: T248551: MathHooks::onMaintenanceRefreshLinksInit isn't registered.Sep 27 2020, 5:08 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 27 2020, 5:11 PM
• Clarakosi moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (External Code Reviews) board.Oct 7 2020, 5:38 PM
gerritbot added a comment.Dec 9 2020, 1:02 AM

Change 647074 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Math@master] MathGenerateTests: Remove use of $wgUser

https://gerrit.wikimedia.org/r/647074

gerritbot added a project: Patch-For-Review.Dec 9 2020, 1:02 AM
DannyS712 moved this task from External Code Review Completed to External Code Review Needed on the Platform Team Workboards (External Code Reviews) board.Dec 9 2020, 1:03 AM
• Clarakosi moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (External Code Reviews) board.Dec 14 2020, 9:05 PM
gerritbot added a comment.Dec 14 2020, 9:57 PM

Change 647074 merged by jenkins-bot:
[mediawiki/extensions/Math@master] MathGenerateTests: Remove use of $wgUser

https://gerrit.wikimedia.org/r/647074

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.22; 2020-12-15); removed MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Dec 14 2020, 10:01 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 14 2020, 10:11 PM
taavi subscribed.Dec 29 2020, 12:35 PM

@DannyS712: is this done? I can't see any uses remaining on codesearch

DannyS712 closed this task as Resolved.Dec 29 2020, 8:40 PM
DannyS712 claimed this task.
In T248550#6713614, @Majavah wrote:

@DannyS712: is this done? I can't see any uses remaining on codesearch

Nope! Thanks for the reminder

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits