The hook to handle MaintenanceRefreshLinksInit isn't registered in the extension.json (the function is only mentioned once in codesearch, where the method is defined - https://codesearch.wmflabs.org/search/?q=onMaintenanceRefreshLinksInit&i=nope&files=&repos= )
Should the handler be removed, given that it is unused, or should it be added to extension.json?
Should the handler be removed, given that it is unused, or should it be added to extension.json?
Good catch. It should be added to extension.json. Otherwise, the maintenance script will be really slow on math-heavy wikis.
Change 630238 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Math@master] Remove use of $wgUser in onMaintenanceRefreshLinksInit
Change 630238 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Remove use of $wgUser in onMaintenanceRefreshLinksInit
Change 630594 had a related patch set uploaded (by Physikerwelt; owner: Physikerwelt):
[mediawiki/extensions/Math@master] Register refresh links hook
@WDoranWMF I was under the impression that there is an obligatory process for code review through the respective boards of your team. I was wondering how https://gerrit.wikimedia.org/r/630238 was scheduled there, or why scheduling was not necessary.
Change 630594 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Register refresh links hook