Page MenuHomePhabricator

Indicators for problematic changes (r) are missing from RC
Open, Needs TriagePublicBUG REPORT


Steps to Reproduce:

  1. Visit recent changes of a wiki which has ORES edit predictions enabled (eg. cswiki, Wikidata).
  2. Use only the filters "Very likely has problems" & "Page edits" (link). Notice there is a legend which explains the meaning of r.
  3. Try both grouped and ungrouped mode, old interface or watchlist.

Actual Results:

  • None of these changes has r indicator, although they are identified as potentially problematic. Highlighting does work.
  • Surprisingly, the indicators can be seen in Special:Contributions.

Expected Results:

  • Changes identified as potentially problematic have r indicator in the recent changes (watchlist).
ungrouped recent changes (cswiki)grouped recent changes (cswiki)contributions
obrazek.png (88×1 px, 13 KB)
obrazek.png (96×1 px, 14 KB)
obrazek.png (138×1 px, 10 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova added a subscriber: Etonkovidova.

Thanks @matej_suchanek
Confirmed - r is not present on Recent changes/Watchlist desplite the legend stating that it should be there. Special:Contirbutions will display r - just as the bug report says.

Special:Preferences#mw-prefsection-rc and Special:Preferences#mw-prefsection-watchlist also display the option "Highlight likely problem edits with colors and an "r" for "needs review"" which also does not add r.

I also checked if users with specific rights - e.g. Reviewers - might see it and it's not the case.

On enwiki the legend has a link to ORES review tool which has an outdated information about r usage and the screenshots that display the usage of r that is not in place anymore.
Moved to "Needs Discussion/Analysis" on Growth team Workboard.

This happens because the ORES extension looks for <span class="mw-changeslist-separator">. .</span> when trying to insert the r (see this code). But the HTML for this changed a number of months ago (these spans are now empty and the dots are injected using CSS), which broke this code.

Change 626193 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/ORES@master] Update delimiter for problematic flag insertion

Change 626193 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Update delimiter for problematic flag insertion

Still does not work in either backend (old and grouped)...

matej_suchanek updated the task description. (Show Details)

Moreover, ChangesListHooksHandler::onOldChangesListRecentChangesLine is supposed to add some CSS classes (damaging, ores-highlight), but they cannot be found in the recent changes list as well. So I suspect from the code that the problem is in ChangesListHooksHandler::getScoreRecentChangesList (used in ChangesListHooksHandler but not in ContributionsHooksHandler).