Page MenuHomePhabricator
Create Task
Maniphest T248567

Expand click zone to open edit interface when selected
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Allow editing on a version only when selected.

Expand click zone to include the entire text box (shown highlighted in green in the image). On click, open editing interface. Disable click zone when de-selected.

v2-edit.png (605×852 px, 357 KB)

Question: Should we also allow expand the click zone for gray boxes to include the entire text area?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Expand the clickable area for the edit button on a selected columnmediawiki/extensions/TwoColConflictmaster+68 -0
Customize query in gerrit

Related Objects

Event Timeline

ECohen_WMDE created this task.Mar 26 2020, 9:43 AM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptMar 26 2020, 9:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lena_WMDE set the point value for this task to 2.Mar 26 2020, 10:00 AM
Lena_WMDE moved this task from Backlog to Product backlog on the Two-Column-Edit-Conflict-Merge board.
ECohen_WMDE mentioned this in T246878: [UX investigation] Change interaction pattern for selecting versions.Mar 27 2020, 10:45 AM
ECohen_WMDE renamed this task from Edit on click in to box to Expand click zone to open edit interface when selected.Mar 27 2020, 1:28 PM
ECohen_WMDE updated the task description. (Show Details)
Lena_WMDE moved this task from Product backlog to Tickets ready for pickup on the Two-Column-Edit-Conflict-Merge board.Apr 1 2020, 10:53 AM
Andrew-WMDE claimed this task.Apr 8 2020, 12:47 PM
Andrew-WMDE added a project: WMDE-QWERTY-Sprint-2020-04-01.
Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-04-01 board.
Andrew-WMDE moved this task from Tickets ready for pickup to Tickets in sprint on the Two-Column-Edit-Conflict-Merge board.Apr 8 2020, 1:56 PM
gerritbot added a comment.Apr 8 2020, 3:15 PM

Change 587542 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/TwoColConflict@master] Expand the clickable area for the edit button on a selected column

https://gerrit.wikimedia.org/r/587542

gerritbot added a project: Patch-For-Review.Apr 8 2020, 3:15 PM
Andrew-WMDE moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2020-04-01 board.Apr 8 2020, 4:00 PM
WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2020-04-01 board.Apr 9 2020, 12:11 PM
gerritbot added a comment.Apr 9 2020, 12:32 PM

Change 587542 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Expand the clickable area for the edit button on a selected column

https://gerrit.wikimedia.org/r/587542

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 9 2020, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 9 2020, 1:10 PM
thiemowmde closed this task as Resolved.Apr 14 2020, 11:36 AM
thiemowmde moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-04-01 board.
thiemowmde subscribed.

We decided to leave the gray boxes untouched for now. Means you must click the edit pen to edit the gray boxes. Reasoning: Typically we don't expect the user to edit the paragraphs where no edit was made before.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits