Page MenuHomePhabricator

Missing edit title description vs introduction alert on article view
Closed, ResolvedPublicBUG REPORT

Description

How many times were you able to reproduce it?

Every time

Steps to reproduce

  1. Go to an article with an article description
  2. Tap the top edit button

Expected results

Expect to see the alert box showing "Edit title description" & "Edit introduction" options (see version 6.5.1)

Actual results

User is taken straight to edit section onboarding.

Screenshots

IMG_0090.PNG (1×750 px, 1 MB)

Environments observed

App version: 6.6.0
OS versions: 13.3.1
Device model: iPhone 7
Device language: EN

Affected articles?

Regression?

Yes

Tag task with Regression

Event Timeline

@Tsevener Are you still able to reproduce this on 6.5.1 (1705)? Using that App Store build on device (iPhone X) without being signed into an account, tapping that edit button ✳️ on the same article (Spinning wheel) results in the same behavior as the latest develop for me: straight to the edit section/onboarding (no intermediate modal with editing options). So for me, I'm encountering the same behavior on both 6.5.1 and 6.6.0.

✳️ unless I'm misinterpreting what the top edit button refers too. Included an annotated screenshot for confirmation.

IMG_0090.png (433×500 px, 929 KB)

@Dmantena hm, there's definitely some weirdness going on with 6.5.1 that might be a separate issue. Sometimes I can trigger the popup and sometimes I can't, but it doesn't seem to be consistent with login status. There might be other logic that varies depending on article that powers this that I'm not aware of. But on 6.6.0 I can't get it to show ever. Try testing with the featured article today (Operation Retribution 1941). You do have the right button.

@Tsevener @Dmantena the descriptions shown in the app are either from Wikidata or Wikipedia. On English wikipedia, editors can override the Wikidata description by using the short description template. In 6.5.1 the expected behavior is that if the description is overriden in the article with that template, the popup isn't shown and the user ends up in the section editor

Change 587594 had a related patch set uploaded (by Joewalsh; owner: Joewalsh):
[mediawiki/services/mobileapps@master] Ensure descriptionSource is passed to clients when the first section edit pencil is tapped

https://gerrit.wikimedia.org/r/587594

The bug is on the page content service side - the interaction event did not contain the descriptionSource anymore. Patch is up and waiting for review.

Change 587594 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Ensure descriptionSource is passed to clients when the first section edit pencil is tapped

https://gerrit.wikimedia.org/r/587594

bearND subscribed.

Deployed earlier today. It took a while for the cached PCS JS module to get purged.