Page MenuHomePhabricator

[EPIC] Standardise template data across MediaWiki skins
Closed, ResolvedPublic

Description

Now that Minerva and Vector are using templates they are diverging with the data they use to render templates. While this is expected it's useful to have some shared commonality in this data and work towards a skin system I've been imagining in https://phabricator.wikimedia.org/phame/post/view/188/why_does_building_a_skin_require_php_knowledge/

Goals

  • Formalise Mustache rendering as part of a skin
  • Use it to render the fallback skin using Mustache
  • Update Vector to make use of the SkinMustache class
  • Upstream generalized menu data from SkinVector to SkinMustache (T262098)
  • Update Minerva to make use of the SkinMustache class (T256083)
  • Upstream data common to Vector and Minerva to the SkinMustache class (T255924)

Possible outcomes

Looking through our skins, one thought I had is that the Modern skin is actually a great candidate for an example of an extremely simplified Mustache skin. My guess is with a new skin architecture in place based on Mustache Modern could be reduced to a single mustache file without any PHP wireup. It would also live up to its name - it would be Modern tech wise if not appearance wise :)

Event Timeline

Change 584068 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Introduce getSkinTemplateData and template-ify fallback skin

https://gerrit.wikimedia.org/r/584068

Change 584068 abandoned by Jdlrobson:
WIP: A modern and restrictive skin system using Mustache

Reason:
I am continuing this inside the Vector skin (https://gerrit.wikimedia.org/r/593070). In future I plan to upstream the generic code there to the SkinMustache class.

https://gerrit.wikimedia.org/r/584068

Jdlrobson renamed this task from Standardise template data across MediaWiki skins to [EPIC] Standardise template data across MediaWiki skins.Jun 29 2020, 11:24 PM
Jdlrobson triaged this task as High priority.
Jdlrobson updated the task description. (Show Details)

Change 639615 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@master] Use the SkinMustache template variable for the main page link

https://gerrit.wikimedia.org/r/639615

Change 639615 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Use the SkinMustache template variable for the main page link

https://gerrit.wikimedia.org/r/639615

Jdlrobson claimed this task.
Jdlrobson updated the task description. (Show Details)

Little point in having this epic open any more. The majority of this is done. More will be learned in T266072