Page MenuHomePhabricator
Create Task
Maniphest T248771

login() with retry=True might delete correct password if unknown APIError occurs
Open, Needs TriagePublic
Actions

Description

See also T248471

Related Objects

Event Timeline

Dvorapa created this task.Mar 29 2020, 3:01 AM
Restricted Application added a project: Pywikibot. · View Herald TranscriptMar 29 2020, 3:01 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald Transcript
Dvorapa added a parent task: T224712: Attempt to login fails several times.Mar 29 2020, 3:01 AM

https://travis-ci.org/github/dvorapa/pywikibot/jobs/668246644#L4474

Dvorapa added a parent task: T248768: clientlogin seems to respond with badtoken instead of NeedToken or WrongToken; but site.tokens is empty when login.Mar 29 2020, 3:07 AM
Dvorapa mentioned this in T222508: action=logout needs CSRF token, since API breaking change.Mar 29 2020, 3:20 AM
Dvorapa added a comment.Mar 29 2020, 4:35 PM

Seems this might really be an issue of zh:ws, but we can't tell for sure until we solve the loops first

Dvorapa renamed this task from login loop 4: get_login_token does poor job urldecoding response and results in badtoken (previously NeedToken) to login loop 4: login process failure not catched by Request.submit() or LoginManager.getCookie() -> catched by LoginManager.login(retry=True) results in deleting password even for passwordfile/noninteractive.Apr 1 2020, 3:29 PM
Dvorapa renamed this task from login loop 4: login process failure not catched by Request.submit() or LoginManager.getCookie() -> catched by LoginManager.login(retry=True) results in deleting password even for passwordfile/noninteractive to login loop 4: login process failure not catched by Request.submit() or LoginManager.getCookie() is passed to LoginManager.login(retry=True) results in deleting password even for passwordfile/noninteractive.
Dvorapa renamed this task from login loop 4: login process failure not catched by Request.submit() or LoginManager.getCookie() is passed to LoginManager.login(retry=True) results in deleting password even for passwordfile/noninteractive to login() with retry=True might delete correct password if unknown APIError occurs.Apr 8 2020, 1:12 PM
Dvorapa updated the task description. (Show Details)
Xqt removed parent tasks: T248768: clientlogin seems to respond with badtoken instead of NeedToken or WrongToken; but site.tokens is empty when login, T224712: Attempt to login fails several times.May 4 2023, 3:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL