Page MenuHomePhabricator

Section 0 (lead) uses first line of wikitext as section title in NWE summary
Closed, ResolvedPublic

Description

This problem might be related to the old T34617.

For many years, I have been using the edit top gadget (or rather its dewiki counterpart), which allows me to easily edit the lead section of an article (very useful function when dealing with e.g. featured articles). Usually, the edit summary would put top (or Einleitung on dewiki) as section title. A couple of days ago, however, the behaviour apparently has changed when using the new wikitext editor; now I always get the content of the very first line of the wikitext as a section title (for example here). It looks like until some time ago, the summary and the section parameter in the URL did not exclude each other, but now they somehow do. The section title in the summary is still as expected when using the old editor.

Since the enwiki and the dewiki gadget are not identical, there is a difference in behaviour: on dewiki, I get summary=%2F%2A+Einleitung+%2A%2F+ and section=0 in the URL, when using the NWE; while on enwiki, with the NWE I only have section=0 in the URL, without any summary definition. Therefore, I do not know whether the problem with NWE might have appeared on enwiki already before (I have not used it for a long time there).

Does somebody know where this changed behaviour originated from? And is there an easy way to predefine the section title also in the NWE summary?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 585029 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Fix issues with treating section "numbers" as integers

https://gerrit.wikimedia.org/r/585029

Change 585029 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix issues with treating section "numbers" as integers

https://gerrit.wikimedia.org/r/585029

Change 585554 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.26] Fix issues with treating section "numbers" as integers

https://gerrit.wikimedia.org/r/585554

Change 585554 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.26] Fix issues with treating section "numbers" as integers

https://gerrit.wikimedia.org/r/585554

Mentioned in SAL (#wikimedia-operations) [2020-04-02T18:22:08Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.26/extensions/VisualEditor/modules/ve-mw: SWAT: 94ded03: Fix issues with treating section "numbers" as integers (T248795; T248968; T249112) (duration: 01m 10s)

matmarex moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.

The bug affects wmf.25 and wmf.26. I only backported it to wmf.26, because the patch did not cherry-pick cleanly to wmf.25, and I didn't want to make last-minute changes to it. wmf.26 should be deployed everywhere in a few hours.