Add sorttop option for jquery.tablesorter
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kaldari
	Mar 31 2020, 2:57 AM

Description

For the COVID-19 infection tables, English Wikipedia wants to put the totals at the top instead of at the bottom. This isn't really supported by jquery.tablesorter, so they implemented an awkward workaround where the totals are part of the header. This has the confusing side effect of putting the sort buttons on the totals instead of the real headers. Several other wikis have now followed this pattern as well: ko, ru, tl, vi, etc. Here's a screenshot:

Screen Shot 2020-03-30 at 10.55.01 PM.png (333×436 px, 72 KB)

It would be nice if jquery.tablesorter added handling for a "sorttop" class similar to the existing "sortbottom" class, so that this could be better accommodated. The "sorttop" row would stick to the top, but not be assigned the sort buttons.

Details

	Subject	Repo	Branch	Lines +/-
	jquery.tablesorter: Allow top sorting via 'sorttop' class	mediawiki/core	master	+43 -13

Customize query in gerrit

Event Timeline

kaldari created this task.Mar 31 2020, 2:57 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2020, 2:57 AM

kaldari updated the task description. (Show Details)Mar 31 2020, 2:58 AM

@Krinkle - I'm not sure who originally wrote jquery.tablesorter (as the history got broken by a file move), but my guess would be you :) Any thoughts on this?

An alternate idea would be a way to assign the sort buttons to a particular row in the header, but that seems hacky.

You could set data-sort-value="-1" or something like that on those rows. https://www.mediawiki.org/wiki/Help:Sorting#Specifying_a_sort_key

(When there are multiple header rows, the sort buttons are added to the bottom-most row with the largest number of cells, to support "grouped" headers – so you could fiddle around with that too.)

In T248936#6013175, @kaldari wrote:

@Krinkle - I'm not sure who originally wrote jquery.tablesorter (as the history got broken by a file move), but my guess would be you :) Any thoughts on this?

It was created by diebuche (Leo Koppelkamm) in 2011. I've since done some of the maintenance.

Tchanders claimed this task.Apr 13 2020, 5:41 PM

Abit moved this task from Incoming to Product Doing on the covid-19 board.Apr 13 2020, 5:42 PM

@Tchanders - If you end up implementing the suggested solution in the description (which is the least hacky solution), let me know and I can update all the tables on-wiki.

Change 588705 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] jquery.tablesorter: Allow top sorting via 'sorttop' class

https://gerrit.wikimedia.org/r/588705

gerritbot added a project: Patch-For-Review.Apr 14 2020, 2:03 PM

Change 588705 merged by jenkins-bot:
[mediawiki/core@master] jquery.tablesorter: Allow top sorting via 'sorttop' class

https://gerrit.wikimedia.org/r/588705

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 17 2020, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 17 2020, 5:10 PM

matmarex closed this task as Resolved.Apr 17 2020, 6:53 PM