Page MenuHomePhabricator

Remove unused PCS JS functionality
Closed, ResolvedPublic

Description

Background information

Some functionality was built into the PCS JS that became unnecessary

What

Remove the unused functionality

  • The ReadMoreTitlesRetrieved interaction handling event is no longer necessary. It was for telling the clients which titles were retrieved so they could update the saved buttons, but the saved buttons were removed.
  • setScrollTop isn't used by either client. Is this causing a bug we aren't aware of or is it no longer necessary?

Feel free to add others here as they are found and before this ticket is picked up.

Event Timeline

Change 699944 had a related patch set uploaded (by Vadim Kovalenko; author: Vadim Kovalenko):

[mediawiki/services/mobileapps@master] Remove unused PCS JS functionality

https://gerrit.wikimedia.org/r/699944

Change 699944 merged by jenkins-bot:

[mediawiki/services/mobileapps@master] Remove unused PCS JS functionality

https://gerrit.wikimedia.org/r/699944