Maniphest T248996

Decouple tokenized request data from InvestigatePager
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	dmaza
	Mar 31 2020, 3:09 PM

Tags

Referenced Files

None

Subscribers

Description

Remove the logic to parse and handle tokenized data on the request from the base class and move it into its own service

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Move token-query business logic into its own class	mediawiki/extensions/CheckUser	master	+281 -199

Customize query in gerrit

Related Objects

Mentioned Here: rECHU22d80dec4fef: Merge "TimelineRowFormatter: Show or redact the comment for the change"

Event Timeline

dmaza created this task.Mar 31 2020, 3:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2020, 3:09 PM

dmaza added a project: Anti-Harassment-Team.Mar 31 2020, 3:11 PM

dmaza moved this task from Untriaged to The Letter Song on the Anti-Harassment-Team board.

dmaza edited projects, added Anti-Harassment-Team (The Letter Song); removed Anti-Harassment-Team.

dmaza moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.

Change 585805 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/extensions/CheckUser@master] [wip] remove investigate-pager

https://gerrit.wikimedia.org/r/585805

gerritbot added a project: Patch-For-Review.Apr 3 2020, 8:44 PM

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Apr 9 2020, 3:32 PM

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (The Letter Song) board.Apr 10 2020, 1:43 PM

Change 585805 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Move token-query business logic into its own class

https://gerrit.wikimedia.org/r/585805

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 10 2020, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 10 2020, 2:10 PM

I did some regression testing of the token functionality on my local environment (CheckUser 2.5 (22d80de) 16:17, 13 May 2020).

Checking that state (including investigated users/ips and filters) persisted across pages, tabs and browser refreshing.

Niharika closed this task as Resolved.May 18 2020, 10:33 PM

Aklapper removed a subscriber: Anti-Harassment-Team.May 16 2023, 1:08 PM