Page MenuHomePhabricator

Hard deprecate RepoGroup::singleton and remove a release later
Closed, ResolvedPublic

Description

RepoGroup::singleton is only used in fallback code for older versions and could be hard deprecated.

Outstanding patch sets for remove deprecated code:
https://gerrit.wikimedia.org/r/#/q/status:open+branch:master+topic:repogroup

All code usages
https://codesearch.wmflabs.org/search/?q=repogroup%5Cs*%3A%3A%5Cs*singleton&i=fosho&files=&repos=

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/PhpTagsWidgetsmaster+1 -1
mediawiki/coremaster+1 -39
mediawiki/extensions/PageImagesmaster+1 -1
mediawiki/extensions/MergeArticlesREL1_35-1.0.x+37 -7
mediawiki/extensions/ContentTransferREL1_35+1 -1
mediawiki/extensions/MergeArticlesREL1_35+37 -7
mediawiki/extensions/BlueSpiceFoundationREL1_35+2 -1
mediawiki/extensions/ContentTransferREL1_35-1.0.x+1 -1
mediawiki/extensions/MergeArticlesmaster+37 -7
mediawiki/extensions/CognitiveProcessDesignerREL1_35+1 -1
mediawiki/extensions/ContentTransfermaster+1 -1
mediawiki/extensions/BlueSpiceFoundationREL1_35-4.2.x+2 -1
mediawiki/extensions/BlueSpiceFoundationmaster+2 -1
mediawiki/extensions/CognitiveProcessDesignerREL1_35-2.0.x+1 -1
mediawiki/extensions/CognitiveProcessDesignermaster+1 -1
mediawiki/coremaster+2 -39
mediawiki/coremaster+16 -7
mediawiki/extensions/EncryptedUploadsmaster+10 -1
mediawiki/extensions/BlueSpicePlayerREL1_35+8 -2
mediawiki/extensions/BlueSpiceFlaggedRevsConnectormaster+6 -4
mediawiki/extensions/BlueSpiceFlaggedRevsConnectorREL1_35+6 -4
mediawiki/extensions/BlueSpicePlayermaster+8 -3
mediawiki/extensions/BlueSpiceExtendedSearchREL1_35+2 -1
mediawiki/extensions/BlueSpiceExtendedSearchmaster+2 -1
mediawiki/extensions/MergeArticlesREL1_35+9 -1
mediawiki/extensions/BlueSpiceBookshelfREL1_35+5 -3
mediawiki/extensions/MergeArticlesmaster+9 -1
mediawiki/extensions/BlueSpiceBookshelfmaster+5 -3
Show related patches Customize query in gerrit

Event Timeline

Zabe added a project: User-Zabe.
Zabe added a subscriber: Zabe.

Change 685067 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/BlueSpiceBookshelf@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685067

Change 685068 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685068

Change 685076 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/BlueSpiceExtendedSearch@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685076

Change 685079 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/BlueSpicePlayer@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685079

Change 685088 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/EncryptedUploads@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685088

Change 685092 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/MergeArticles@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685092

Change 685054 had a related patch set uploaded (by Pwirth; author: Zabe):

[mediawiki/extensions/BlueSpiceBookshelf@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685054

Change 685055 had a related patch set uploaded (by Pwirth; author: Zabe):

[mediawiki/extensions/MergeArticles@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685055

Change 685067 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceBookshelf@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685067

Change 685054 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceBookshelf@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685054

Change 685092 merged by jenkins-bot:

[mediawiki/extensions/MergeArticles@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685092

Change 685055 merged by jenkins-bot:

[mediawiki/extensions/MergeArticles@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685055

Change 685057 had a related patch set uploaded (by Pwirth; author: Zabe):

[mediawiki/extensions/BlueSpiceExtendedSearch@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685057

Change 685058 had a related patch set uploaded (by Pwirth; author: Zabe):

[mediawiki/extensions/BlueSpicePlayer@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685058

Change 685076 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceExtendedSearch@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685076

Change 685057 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceExtendedSearch@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685057

Change 685059 had a related patch set uploaded (by Pwirth; author: Zabe):

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685059

Change 685079 merged by jenkins-bot:

[mediawiki/extensions/BlueSpicePlayer@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685079

Change 685059 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685059

Change 685068 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685068

Change 685058 merged by jenkins-bot:

[mediawiki/extensions/BlueSpicePlayer@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685058

Change 685742 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Hard deprecate RepoGroup::singleton(), ::destroySingletons() and ::setSingleton()

https://gerrit.wikimedia.org/r/685742

Change 685088 merged by jenkins-bot:

[mediawiki/extensions/EncryptedUploads@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685088

I guess this is done, right?

I guess this is done, right?

Not removed yet. :-) Looks like it's ready to be hard-deprecated though.

I guess this is done, right?

Not removed yet. :-) Looks like it's ready to be hard-deprecated though.

It is what I mean.

Change 685742 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate RepoGroup methods

https://gerrit.wikimedia.org/r/685742

Change 721550 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Remove deprecated RepoGroup methods

https://gerrit.wikimedia.org/r/721550

Change 721550 merged by jenkins-bot:

[mediawiki/core@master] Remove deprecated RepoGroup methods

https://gerrit.wikimedia.org/r/721550

Change 812054 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Remove deprecated wfLocalFile and wfFindFile

https://gerrit.wikimedia.org/r/812054

Change 812067 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CognitiveProcessDesigner@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812067

Change 812068 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ContentTransfer@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812068

Change 812069 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PhpTagsWidgets@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812069

Change 812070 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlueSpiceFoundation@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812070

Change 812072 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MergeArticles@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812072

Change 812073 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageImages@master] Replace comment about deprecated wfFindFile

https://gerrit.wikimedia.org/r/812073

Change 812067 merged by Robert Vogel:

[mediawiki/extensions/CognitiveProcessDesigner@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812067

Change 812120 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/CognitiveProcessDesigner@REL1_35] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812120

Change 812120 merged by Robert Vogel:

[mediawiki/extensions/CognitiveProcessDesigner@REL1_35] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812120

Change 812121 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/CognitiveProcessDesigner@REL1_35-2.0.x] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812121

Change 812121 merged by Robert Vogel:

[mediawiki/extensions/CognitiveProcessDesigner@REL1_35-2.0.x] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812121

Change 812122 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/MergeArticles@REL1_35] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812122

Change 812123 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/MergeArticles@REL1_35-1.0.x] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812123

Change 812070 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceFoundation@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812070

Change 812124 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/BlueSpiceFoundation@REL1_35] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812124

Change 812124 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceFoundation@REL1_35] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812124

Change 812125 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/BlueSpiceFoundation@REL1_35-4.2.x] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812125

Change 812125 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceFoundation@REL1_35-4.2.x] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812125

Change 812068 merged by Robert Vogel:

[mediawiki/extensions/ContentTransfer@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812068

Change 812266 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/ContentTransfer@REL1_35] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812266

Change 812266 merged by Robert Vogel:

[mediawiki/extensions/ContentTransfer@REL1_35] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812266

Change 812072 merged by jenkins-bot:

[mediawiki/extensions/MergeArticles@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812072

Change 812267 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/ContentTransfer@REL1_35-1.0.x] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812267

Change 812267 merged by Robert Vogel:

[mediawiki/extensions/ContentTransfer@REL1_35-1.0.x] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812267

Change 812122 merged by jenkins-bot:

[mediawiki/extensions/MergeArticles@REL1_35] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812122

Change 812123 merged by Robert Vogel:

[mediawiki/extensions/MergeArticles@REL1_35-1.0.x] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812123

Change 812073 merged by jenkins-bot:

[mediawiki/extensions/PageImages@master] Replace comment about deprecated wfFindFile

https://gerrit.wikimedia.org/r/812073

Change 812054 merged by jenkins-bot:

[mediawiki/core@master] Remove deprecated wfLocalFile and wfFindFile

https://gerrit.wikimedia.org/r/812054

Change 812069 merged by Zabe:

[mediawiki/extensions/PhpTagsWidgets@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812069