Page MenuHomePhabricator
Create Task
Maniphest T249020

Hard deprecate RepoGroup::singleton and remove a release later
Closed, ResolvedPublic
Actions

Description

RepoGroup::singleton is only used in fallback code for older versions and could be hard deprecated.

Outstanding patch sets for remove deprecated code:
https://gerrit.wikimedia.org/r/#/q/status:open+branch:master+topic:repogroup

All code usages
https://codesearch.wmflabs.org/search/?q=repogroup%5Cs*%3A%3A%5Cs*singleton&i=fosho&files=&repos=

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Replace deprecated wfFindFileUmherirrendermediawiki/extensions/PhpTagsWidgetsmaster+1 -1
Remove deprecated wfLocalFile and wfFindFileUmherirrendermediawiki/coremaster+1 -39
Replace comment about deprecated wfFindFileUmherirrendermediawiki/extensions/PageImagesmaster+1 -1
Replace deprecated wfFindFileRobert Vogelmediawiki/extensions/MergeArticlesREL1_35-1.0.x+37 -7
Replace deprecated wfFindFileRobert Vogelmediawiki/extensions/ContentTransferREL1_35+1 -1
Replace deprecated wfFindFileRobert Vogelmediawiki/extensions/MergeArticlesREL1_35+37 -7
Replace deprecated wfFindFileRobert Vogelmediawiki/extensions/BlueSpiceFoundationREL1_35+2 -1
Replace deprecated wfFindFileRobert Vogelmediawiki/extensions/ContentTransferREL1_35-1.0.x+1 -1
Replace deprecated wfFindFileUmherirrendermediawiki/extensions/MergeArticlesmaster+37 -7
Replace deprecated wfFindFileRobert Vogelmediawiki/extensions/CognitiveProcessDesignerREL1_35+1 -1
Replace deprecated wfFindFileUmherirrendermediawiki/extensions/ContentTransfermaster+1 -1
Replace deprecated wfFindFileRobert Vogelmediawiki/extensions/BlueSpiceFoundationREL1_35-4.2.x+2 -1
Replace deprecated wfFindFileUmherirrendermediawiki/extensions/BlueSpiceFoundationmaster+2 -1
Replace deprecated wfFindFileRobert Vogelmediawiki/extensions/CognitiveProcessDesignerREL1_35-2.0.x+1 -1
Replace deprecated wfFindFileUmherirrendermediawiki/extensions/CognitiveProcessDesignermaster+1 -1
Remove deprecated RepoGroup methodsZabemediawiki/coremaster+2 -39
Hard deprecate RepoGroup methodsZabemediawiki/coremaster+16 -7
Avoid using RepoGroup::singleton()Zabemediawiki/extensions/EncryptedUploadsmaster+10 -1
Avoid using RepoGroup::singleton()Pwirthmediawiki/extensions/BlueSpicePlayerREL1_35+8 -2
Avoid using RepoGroup::singleton()Zabemediawiki/extensions/BlueSpiceFlaggedRevsConnectormaster+6 -4
Avoid using RepoGroup::singleton()Pwirthmediawiki/extensions/BlueSpiceFlaggedRevsConnectorREL1_35+6 -4
Avoid using RepoGroup::singleton()Zabemediawiki/extensions/BlueSpicePlayermaster+8 -3
Avoid using RepoGroup::singleton()Pwirthmediawiki/extensions/BlueSpiceExtendedSearchREL1_35+2 -1
Avoid using RepoGroup::singleton()Zabemediawiki/extensions/BlueSpiceExtendedSearchmaster+2 -1
Avoid using RepoGroup::singleton()Pwirthmediawiki/extensions/MergeArticlesREL1_35+9 -1
Avoid using RepoGroup::singleton()Pwirthmediawiki/extensions/BlueSpiceBookshelfREL1_35+5 -3
Avoid using RepoGroup::singleton()Zabemediawiki/extensions/MergeArticlesmaster+9 -1
Avoid using RepoGroup::singleton()Zabemediawiki/extensions/BlueSpiceBookshelfmaster+5 -3
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Mar 31 2020, 5:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2020, 5:11 PM
DannyS712 edited projects, added: Technical-Debt (Deprecation process); removed: Technical-Debt.Mar 31 2020, 5:13 PM
DannyS712 subscribed.
Umherirrender added a comment.Mar 31 2020, 5:24 PM

Same for RepoGroup::destroySingleton

https://codesearch.wmflabs.org/search/?q=repogroup%5Cs*%3A%3A%5Cs*destroySingleton&i=fosho&files=&repos=

And RepoGroup::setSingleton

https://codesearch.wmflabs.org/search/?q=repogroup%5Cs*%3A%3A%5Cs*setSingleton&i=fosho&files=&repos=

Umherirrender added a comment.Apr 4 2020, 5:45 PM

Also for wfFindFile
https://codesearch.wmflabs.org/search/?q=wfFindFile&i=fosho&files=&repos=

And wfLocalFile
https://codesearch.wmflabs.org/search/?q=wfLocalFile&i=fosho&files=&repos=

Zabe claimed this task.May 3 2021, 2:01 PM
Zabe added a project: User-Zabe.
Zabe subscribed.
gerritbot added a comment.May 4 2021, 7:21 PM

Change 685067 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/BlueSpiceBookshelf@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685067

gerritbot added a project: Patch-For-Review.May 4 2021, 7:21 PM
gerritbot added a comment.May 4 2021, 7:33 PM

Change 685068 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685068

gerritbot added a comment.May 4 2021, 7:45 PM

Change 685076 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/BlueSpiceExtendedSearch@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685076

gerritbot added a comment.May 4 2021, 7:53 PM

Change 685079 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/BlueSpicePlayer@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685079

gerritbot added a comment.May 4 2021, 8:12 PM

Change 685088 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/EncryptedUploads@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685088

gerritbot added a comment.May 4 2021, 8:24 PM

Change 685092 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/MergeArticles@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685092

gerritbot added a comment.May 5 2021, 8:01 AM

Change 685054 had a related patch set uploaded (by Pwirth; author: Zabe):

[mediawiki/extensions/BlueSpiceBookshelf@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685054

gerritbot added a comment.May 5 2021, 8:02 AM

Change 685055 had a related patch set uploaded (by Pwirth; author: Zabe):

[mediawiki/extensions/MergeArticles@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685055

gerritbot added a comment.May 5 2021, 8:05 AM

Change 685067 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceBookshelf@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685067

gerritbot added a comment.May 5 2021, 8:06 AM

Change 685054 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceBookshelf@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685054

gerritbot added a comment.May 5 2021, 8:07 AM

Change 685092 merged by jenkins-bot:

[mediawiki/extensions/MergeArticles@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685092

gerritbot added a comment.May 5 2021, 8:07 AM

Change 685055 merged by jenkins-bot:

[mediawiki/extensions/MergeArticles@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685055

Zabe mentioned this in rEBKM10158fb28a95: Avoid using RepoGroup::singleton().May 5 2021, 8:08 AM
Pwirth mentioned this in rEBKM28945781878d: Avoid using RepoGroup::singleton().May 5 2021, 8:08 AM
gerritbot added a comment.May 5 2021, 10:58 AM

Change 685057 had a related patch set uploaded (by Pwirth; author: Zabe):

[mediawiki/extensions/BlueSpiceExtendedSearch@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685057

gerritbot added a comment.May 5 2021, 10:59 AM

Change 685058 had a related patch set uploaded (by Pwirth; author: Zabe):

[mediawiki/extensions/BlueSpicePlayer@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685058

gerritbot added a comment.May 5 2021, 11:02 AM

Change 685076 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceExtendedSearch@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685076

gerritbot added a comment.May 5 2021, 11:03 AM

Change 685057 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceExtendedSearch@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685057

Zabe mentioned this in rEBSEScfd86815c60e: Avoid using RepoGroup::singleton().May 5 2021, 11:04 AM
Pwirth mentioned this in rEBSEScd0791af642a: Avoid using RepoGroup::singleton().May 5 2021, 11:04 AM
gerritbot added a comment.May 5 2021, 11:04 AM

Change 685059 had a related patch set uploaded (by Pwirth; author: Zabe):

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685059

gerritbot added a comment.May 5 2021, 11:04 AM

Change 685079 merged by jenkins-bot:

[mediawiki/extensions/BlueSpicePlayer@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685079

gerritbot added a comment.May 5 2021, 11:09 AM

Change 685059 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685059

gerritbot added a comment.May 5 2021, 11:09 AM

Change 685068 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685068

gerritbot added a comment.May 5 2021, 12:49 PM

Change 685058 merged by jenkins-bot:

[mediawiki/extensions/BlueSpicePlayer@REL1_35] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685058

gerritbot added a comment.May 6 2021, 9:31 AM

Change 685742 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Hard deprecate RepoGroup::singleton(), ::destroySingletons() and ::setSingleton()

https://gerrit.wikimedia.org/r/685742

Zabe moved this task from Backlog to Deprecation on the User-Zabe board.May 6 2021, 10:53 AM
gerritbot added a comment.May 24 2021, 3:27 PM

Change 685088 merged by jenkins-bot:

[mediawiki/extensions/EncryptedUploads@master] Avoid using RepoGroup::singleton()

https://gerrit.wikimedia.org/r/685088

Zabe mentioned this in rEEUPdd4c306d7b17: Avoid using RepoGroup::singleton().May 24 2021, 3:30 PM
Kizule subscribed.May 24 2021, 11:20 PM

I guess this is done, right?

Jdforrester-WMF subscribed.May 24 2021, 11:30 PM
In T249020#7109875, @Kizule wrote:

I guess this is done, right?

Not removed yet. :-) Looks like it's ready to be hard-deprecated though.

Kizule added a comment.May 24 2021, 11:34 PM
In T249020#7109886, @Jdforrester-WMF wrote:
In T249020#7109875, @Kizule wrote:

I guess this is done, right?

Not removed yet. :-) Looks like it's ready to be hard-deprecated though.

It is what I mean.

gerritbot added a comment.May 28 2021, 12:09 AM

Change 685742 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate RepoGroup methods

https://gerrit.wikimedia.org/r/685742

Zabe removed a project: Patch-For-Review.Jul 13 2021, 12:24 AM
gerritbot added a comment.Sep 16 2021, 2:13 PM

Change 721550 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Remove deprecated RepoGroup methods

https://gerrit.wikimedia.org/r/721550

gerritbot added a project: Patch-For-Review.Sep 16 2021, 2:13 PM
gerritbot added a comment.Sep 17 2021, 3:30 AM

Change 721550 merged by jenkins-bot:

[mediawiki/core@master] Remove deprecated RepoGroup methods

https://gerrit.wikimedia.org/r/721550

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 17 2021, 4:00 AM
Zabe closed this task as Resolved.Sep 17 2021, 5:43 AM
Zabe removed a project: User-Zabe.Apr 13 2022, 1:21 AM
gerritbot added a comment.Jul 7 2022, 6:44 PM

Change 812054 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Remove deprecated wfLocalFile and wfFindFile

https://gerrit.wikimedia.org/r/812054

gerritbot added a comment.Jul 7 2022, 7:49 PM

Change 812067 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CognitiveProcessDesigner@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812067

gerritbot added a comment.Jul 7 2022, 7:49 PM

Change 812068 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ContentTransfer@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812068

gerritbot added a comment.Jul 7 2022, 7:50 PM

Change 812069 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PhpTagsWidgets@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812069

gerritbot added a comment.Jul 7 2022, 7:51 PM

Change 812070 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlueSpiceFoundation@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812070

gerritbot added a comment.Jul 7 2022, 7:58 PM

Change 812072 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MergeArticles@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812072

gerritbot added a comment.Jul 7 2022, 8:04 PM

Change 812073 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageImages@master] Replace comment about deprecated wfFindFile

https://gerrit.wikimedia.org/r/812073

gerritbot added a comment.Jul 8 2022, 9:58 AM

Change 812067 merged by Robert Vogel:

[mediawiki/extensions/CognitiveProcessDesigner@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812067

gerritbot added a comment.Jul 8 2022, 9:59 AM

Change 812120 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/CognitiveProcessDesigner@REL1_35] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812120

gerritbot added a comment.Jul 8 2022, 9:59 AM

Change 812120 merged by Robert Vogel:

[mediawiki/extensions/CognitiveProcessDesigner@REL1_35] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812120

gerritbot added a comment.Jul 8 2022, 9:59 AM

Change 812121 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/CognitiveProcessDesigner@REL1_35-2.0.x] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812121

gerritbot added a comment.Jul 8 2022, 9:59 AM

Change 812121 merged by Robert Vogel:

[mediawiki/extensions/CognitiveProcessDesigner@REL1_35-2.0.x] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812121

Osnard mentioned this in rECPD04f3664a6eee: Replace deprecated wfFindFile.Jul 8 2022, 10:00 AM
Osnard mentioned this in rECPD78ce6b5fdff7: Replace deprecated wfFindFile.
Umherirrender mentioned this in rECPDc4278f07afca: Replace deprecated wfFindFile.Jul 8 2022, 10:00 AM
gerritbot added a comment.Jul 8 2022, 10:01 AM

Change 812122 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/MergeArticles@REL1_35] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812122

gerritbot added a comment.Jul 8 2022, 10:01 AM

Change 812123 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/MergeArticles@REL1_35-1.0.x] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812123

gerritbot added a comment.Jul 8 2022, 10:01 AM

Change 812070 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceFoundation@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812070

gerritbot added a comment.Jul 8 2022, 10:01 AM

Change 812124 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/BlueSpiceFoundation@REL1_35] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812124

gerritbot added a comment.Jul 8 2022, 10:01 AM

Change 812124 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceFoundation@REL1_35] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812124

gerritbot added a comment.Jul 8 2022, 10:01 AM

Change 812125 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/BlueSpiceFoundation@REL1_35-4.2.x] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812125

gerritbot added a comment.Jul 8 2022, 10:02 AM

Change 812125 merged by Robert Vogel:

[mediawiki/extensions/BlueSpiceFoundation@REL1_35-4.2.x] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812125

gerritbot added a comment.Jul 8 2022, 10:02 AM

Change 812068 merged by Robert Vogel:

[mediawiki/extensions/ContentTransfer@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812068

gerritbot added a comment.Jul 8 2022, 10:02 AM

Change 812266 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/ContentTransfer@REL1_35] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812266

gerritbot added a comment.Jul 8 2022, 10:02 AM

Change 812266 merged by Robert Vogel:

[mediawiki/extensions/ContentTransfer@REL1_35] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812266

gerritbot added a comment.Jul 8 2022, 10:02 AM

Change 812072 merged by jenkins-bot:

[mediawiki/extensions/MergeArticles@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812072

Osnard mentioned this in rEBKL4a567045572b: Replace deprecated wfFindFile.Jul 8 2022, 10:02 AM
gerritbot added a comment.Jul 8 2022, 10:02 AM

Change 812267 had a related patch set uploaded (by Robert Vogel; author: Umherirrender):

[mediawiki/extensions/ContentTransfer@REL1_35-1.0.x] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812267

Umherirrender mentioned this in rEBKLf3fb3441403c: Replace deprecated wfFindFile.Jul 8 2022, 10:02 AM
Umherirrender mentioned this in rEBKM478122e1b519: Replace deprecated wfFindFile.
gerritbot added a comment.Jul 8 2022, 10:03 AM

Change 812267 merged by Robert Vogel:

[mediawiki/extensions/ContentTransfer@REL1_35-1.0.x] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812267

Osnard mentioned this in rEBKLff617ac9a063: Replace deprecated wfFindFile.Jul 8 2022, 10:03 AM
gerritbot added a comment.Jul 8 2022, 10:05 AM

Change 812122 merged by jenkins-bot:

[mediawiki/extensions/MergeArticles@REL1_35] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812122

Osnard mentioned this in rEBKM622a0dba57bf: Replace deprecated wfFindFile.Jul 8 2022, 10:05 AM
gerritbot added a comment.Jul 8 2022, 11:43 AM

Change 812123 merged by Robert Vogel:

[mediawiki/extensions/MergeArticles@REL1_35-1.0.x] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812123

Osnard mentioned this in rEBKM202a72c1afd1: Replace deprecated wfFindFile.Jul 8 2022, 11:43 AM
gerritbot added a comment.Jul 8 2022, 3:22 PM

Change 812073 merged by jenkins-bot:

[mediawiki/extensions/PageImages@master] Replace comment about deprecated wfFindFile

https://gerrit.wikimedia.org/r/812073

gerritbot added a comment.Jul 8 2022, 3:26 PM

Change 812054 merged by jenkins-bot:

[mediawiki/core@master] Remove deprecated wfLocalFile and wfFindFile

https://gerrit.wikimedia.org/r/812054

gerritbot added a comment.Jul 8 2022, 6:33 PM

Change 812069 merged by Zabe:

[mediawiki/extensions/PhpTagsWidgets@master] Replace deprecated wfFindFile

https://gerrit.wikimedia.org/r/812069

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 6:02 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits