Page MenuHomePhabricator

Hard deprecate Revision::newFromId
Closed, ResolvedPublic

Description

Lots of uses

https://codesearch.wmflabs.org/deployed/?q=Revision%3A%3AnewFromId&i=nope&files=&repos=

  • Core
  • Wikibase
  • FlaggedRevs
  • Flow
  • CheckUser
  • EventLogging
  • LiquidThreads
  • MobileFrontend
  • Translate
  • Cognate
  • Jade
  • Newsletter
  • ParsoidBatchAPI

Remaining core uses:

  • EditPage
  • MediaWiki.php
  • WikiPage::replaceSectionAtRev
  • CheckBadRedirects
  • ImportTextFiles

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+9 -0
mediawiki/coremaster+7 -3
mediawiki/coremaster+10 -5
mediawiki/coremaster+8 -2
mediawiki/coremaster+3 -3
mediawiki/coremaster+14 -4
mediawiki/coremaster+163 -125
mediawiki/coremaster+12 -5
mediawiki/coremaster+34 -27
mediawiki/coremaster+5 -3
mediawiki/coremaster+86 -61
mediawiki/coremaster+35 -21
mediawiki/coremaster+19 -5
mediawiki/coremaster+15 -9
mediawiki/coremaster+16 -9
mediawiki/coremaster+10 -5
mediawiki/extensions/Wikibasemaster+44 -18
mediawiki/extensions/EventLoggingmaster+24 -11
mediawiki/coremaster+32 -19
mediawiki/extensions/Wikibasemaster+58 -34
mediawiki/extensions/Wikibasemaster+42 -38
mediawiki/extensions/Translatemaster+10 -5
mediawiki/extensions/FlaggedRevsmaster+551 -299
mediawiki/extensions/Jademaster+83 -52
mediawiki/extensions/MobileFrontendmaster+7 -3
mediawiki/extensions/Translatemaster+39 -31
mediawiki/extensions/Newslettermaster+30 -14
mediawiki/extensions/Newslettermaster+21 -13
mediawiki/extensions/MobileFrontendmaster+32 -23
mediawiki/extensions/CheckUsermaster+14 -12
mediawiki/extensions/Flowmaster+8 -6
mediawiki/extensions/LiquidThreadsmaster+16 -6
mediawiki/extensions/ParsoidBatchAPImaster+4 -4
mediawiki/extensions/Cognatemaster+13 -8
mediawiki/extensions/ApprovedRevsmaster+18 -3
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 585831 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] Remove use of Revision::newFromId

https://gerrit.wikimedia.org/r/585831

Change 585832 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CheckUser@master] Remove use of Revision::newFromId

https://gerrit.wikimedia.org/r/585832

Change 585835 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/EventLogging@master] Remove use of Revision::newFromId

https://gerrit.wikimedia.org/r/585835

Change 585831 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Remove use of Revision::newFromId

https://gerrit.wikimedia.org/r/585831

Change 585832 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Remove use of Revision::newFromId

https://gerrit.wikimedia.org/r/585832

Change 556811 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Breaking: Drop InlineDiffFormatter and InlineDifferenceEngine

https://gerrit.wikimedia.org/r/556811

Change 585786 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove use of Revision::newFromId

https://gerrit.wikimedia.org/r/585786

Note the remaining code in MobileFrontend that makes use of this is never run in production and scheduled for removal this coming release. So I guess this is blocked on T240622 (not sure if you want to formalise this in Phabricator) xx?

Change 586442 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Remove use of Revision::newFromId

https://gerrit.wikimedia.org/r/586442

Change 586445 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Remove use of Revision::newFromId

https://gerrit.wikimedia.org/r/586445

Change 586450 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Newsletter@master] Remove use of Revision::newFromId

https://gerrit.wikimedia.org/r/586450

Change 586450 abandoned by DannyS712:
Remove use of Revision::newFromId

Reason:
...so I already did this at Ia60f12701760f0284064c7ec18acb355583d97e9

https://gerrit.wikimedia.org/r/586450

Change 585785 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] Remove use of Revision::newFromId

https://gerrit.wikimedia.org/r/585785

Change 583164 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] WikiPage::getUndoContent - support RevisionRecord

https://gerrit.wikimedia.org/r/583164

Change 586442 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Remove use of Revision::newFromId

https://gerrit.wikimedia.org/r/586442

Change 587527 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Remove the other use of Revision::newFromId

https://gerrit.wikimedia.org/r/587527

Change 587528 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] Remove remaining use of Revision::newFromId

https://gerrit.wikimedia.org/r/587528

Change 587528 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove remaining use of Revision::newFromId

https://gerrit.wikimedia.org/r/587528

Change 586445 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Remove use of Revision::newFromId, use RevisionRecord in Linker methods

https://gerrit.wikimedia.org/r/586445

Change 585376 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Remove use of Revision objects to the extent possible

https://gerrit.wikimedia.org/r/585376

Change 587527 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Remove the other use of Revision::newFromId

https://gerrit.wikimedia.org/r/587527

Change 589025 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] Remove some uses of Revision::newFromId

https://gerrit.wikimedia.org/r/589025

Change 589025 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove some uses of Revision::newFromId

https://gerrit.wikimedia.org/r/589025

Change 591021 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] ChangeNotifier::notifyOnPageUndeleted - use RevisionRecord

https://gerrit.wikimedia.org/r/591021

Change 591021 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] ChangeNotifier - use RevisionRecord

https://gerrit.wikimedia.org/r/591021

Change 583164 abandoned by Ppchelko:
WikiPage::getUndoContent - support RevisionRecord

https://gerrit.wikimedia.org/r/583164

Change 591531 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] MediaWikiIntegrationTestCase: Remove use of Revision objects

https://gerrit.wikimedia.org/r/591531

Change 592319 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Article::setOldSubtitle - reduce use of Revision objects

https://gerrit.wikimedia.org/r/592319

Change 592321 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] WikiPage::updateRevisionOn - replace uses, hard deprecate Revision use

https://gerrit.wikimedia.org/r/592321

Change 592512 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Wikibase@master] Remove uses of Revision::newFromId

https://gerrit.wikimedia.org/r/592512

Change 592732 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] FeedUtils: Remove use of Revision objects

https://gerrit.wikimedia.org/r/592732

Change 592736 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] SpecialComparePages: Remove use of Revision objects

https://gerrit.wikimedia.org/r/592736

Change 585835 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] Remove use of Revision::newFromId

https://gerrit.wikimedia.org/r/585835

Change 592512 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove uses of Revision::newFromId

https://gerrit.wikimedia.org/r/592512

Only core left (for deployed uses):

Change 593272 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove DifferenceEngine::$mNewRev and $mOldRev

https://gerrit.wikimedia.org/r/593272

Change 591531 merged by jenkins-bot:
[mediawiki/core@master] MediaWikiIntegrationTestCase: Remove use of Revision objects

https://gerrit.wikimedia.org/r/591531

Change 592732 merged by jenkins-bot:
[mediawiki/core@master] FeedUtils: Remove use of Revision objects

https://gerrit.wikimedia.org/r/592732

Change 592736 merged by jenkins-bot:
[mediawiki/core@master] SpecialComparePages: Remove use of Revision objects

https://gerrit.wikimedia.org/r/592736

Change 592319 merged by jenkins-bot:
[mediawiki/core@master] Article::setOldSubtitle - reduce use of Revision objects

https://gerrit.wikimedia.org/r/592319

Change 592321 merged by jenkins-bot:
[mediawiki/core@master] WikiPage::updateRevisionOn - replace uses, hard deprecate Revision use

https://gerrit.wikimedia.org/r/592321

Change 593826 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Replace Article::$mRevision with RevisionRecord

https://gerrit.wikimedia.org/r/593826

Update re current uses:

Change 594253 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove use of Revision objects in SpecialNewpages::feedItemDesc

https://gerrit.wikimedia.org/r/594253

Change 593826 merged by jenkins-bot:
[mediawiki/core@master] Replace Article::$mRevision with RevisionRecord

https://gerrit.wikimedia.org/r/593826

Change 593785 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove use of Revision objects in RevisionItem classes

https://gerrit.wikimedia.org/r/593785

Change 594340 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] ChangeTags::updateTagsWithChecks - remove use of Revision objects

https://gerrit.wikimedia.org/r/594340

Change 594340 merged by jenkins-bot:
[mediawiki/core@master] ChangeTags::updateTagsWithChecks - remove use of Revision objects

https://gerrit.wikimedia.org/r/594340

Change 593785 merged by jenkins-bot:
[mediawiki/core@master] Remove use of Revision objects in RevisionItem classes

https://gerrit.wikimedia.org/r/593785

Change 594253 merged by jenkins-bot:
[mediawiki/core@master] Remove use of Revision objects in SpecialNewpages::feedItemDesc

https://gerrit.wikimedia.org/r/594253

Change 593272 merged by jenkins-bot:
[mediawiki/core@master] Remove DifferenceEngine::$mNewRev and $mOldRev

https://gerrit.wikimedia.org/r/593272

Change 599138 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] EditPage::edit - remove use of Revision objects

https://gerrit.wikimedia.org/r/599138

Change 599138 merged by jenkins-bot:
[mediawiki/core@master] EditPage::edit - remove use of Revision objects

https://gerrit.wikimedia.org/r/599138

Change 601911 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] importTextFiles: Remove use of Revision objects

https://gerrit.wikimedia.org/r/601911

Change 601912 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] checkBadRedirects: Remove use of Revision objects

https://gerrit.wikimedia.org/r/601912

Change 601913 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] WikiPage::replaceSectionAtRev - remove use of Revision objects

https://gerrit.wikimedia.org/r/601913

Change 601915 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] MediaWiki::parseTitle - remove use of Revision objects

https://gerrit.wikimedia.org/r/601915

@Pchelolo @BPirkle @CCicalese_WMF patches are pending to replace all remaining uses in core outside of tests, and then this can be hard deprecated

@Pchelolo @BPirkle @CCicalese_WMF patches are pending to replace all remaining uses in core outside of tests, and then this can be hard deprecated

All merged.

Change 601915 merged by jenkins-bot:
[mediawiki/core@master] MediaWiki::parseTitle - remove use of Revision objects

https://gerrit.wikimedia.org/r/601915

Change 601913 merged by jenkins-bot:
[mediawiki/core@master] WikiPage::replaceSectionAtRev - remove use of Revision objects

https://gerrit.wikimedia.org/r/601913

Change 601912 merged by jenkins-bot:
[mediawiki/core@master] checkBadRedirects: Remove use of Revision objects

https://gerrit.wikimedia.org/r/601912

Change 601911 merged by jenkins-bot:
[mediawiki/core@master] importTextFiles: Remove use of Revision objects

https://gerrit.wikimedia.org/r/601911

Change 601929 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::newFromId

https://gerrit.wikimedia.org/r/601929

Change 601929 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Revision::newFromId

https://gerrit.wikimedia.org/r/601929

DannyS712 removed a project: Patch-For-Review.
DannyS712 updated the task description. (Show Details)