Maniphest T249025

Hard deprecate FileBackendGroup::singleton and remove a release later
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Mar 31 2020, 5:49 PM

Tags

Referenced Files

None

Subscribers

Description

FileBackendGroup::singleton is only used in fallback code for older versions and could be hard deprecated.

https://codesearch.wmflabs.org/search/?q=FileBackendGroup%5Cs*%3A%3A%5Cs*singleton&i=fosho&files=&repos=

FileBackendGroup::destroySingleton

https://codesearch.wmflabs.org/search/?q=FileBackendGroup%5Cs*%3A%3A%5Cs*destroySingleton&i=fosho&files=&repos=

Outstanding patch sets for remove deprecated code:
https://gerrit.wikimedia.org/r/#/q/topic:filebackendgroup+(status:open+OR+status:merged)

Details

	Subject	Repo	Branch	Lines +/-
	Remove FileBackendGroup::singleton() and ::destroySingletons()	mediawiki/core	master	+4 -26
	Hard deprecate FileBackendGroup::singleton() and ::destroySingletons()	mediawiki/core	master	+11 -4

Customize query in gerrit

Event Timeline

Umherirrender created this task.Mar 31 2020, 5:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2020, 5:49 PM

Aklapper edited projects, added MediaWiki-File-management; removed MediaWiki-General.Apr 1 2020, 12:29 PM

Restricted Application added a project: Commons. · View Herald TranscriptApr 1 2020, 12:29 PM

Zabe claimed this task.May 3 2021, 1:57 PM

Zabe added a project: User-Zabe.

Zabe subscribed.

Change 684491 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Hard deprecate FileBackendGroup::singleton() and ::destroySingletons()

https://gerrit.wikimedia.org/r/684491

gerritbot added a project: Patch-For-Review.May 3 2021, 7:23 PM

Change 684491 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate FileBackendGroup::singleton() and ::destroySingletons()

https://gerrit.wikimedia.org/r/684491

Maintenance_bot removed a project: Patch-For-Review.May 4 2021, 9:10 PM

Zabe moved this task from Backlog to Deprecation on the User-Zabe board.May 6 2021, 10:53 AM

Change 721354 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Remove FileBackendGroup::singleton() and ::destroySingletons()

https://gerrit.wikimedia.org/r/721354

gerritbot added a project: Patch-For-Review.Sep 15 2021, 4:37 PM

Change 721354 merged by jenkins-bot:

[mediawiki/core@master] Remove FileBackendGroup::singleton() and ::destroySingletons()

https://gerrit.wikimedia.org/r/721354

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 16 2021, 3:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2021, 3:11 AM

Zabe closed this task as Resolved.Sep 16 2021, 5:47 AM

Zabe removed a project: User-Zabe.Apr 13 2022, 1:21 AM