Add support in toolbar for special characters within DiscussionTools
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ppelberg
	Mar 31 2020, 11:51 PM

Description

The lack of a menu/editing tool to insert special characters (e.g. diacritical marks) can make it difficult for people writing in languages like French, Dutch, Hungarian to fully express what they are trying to using the New Discussoin and Reply Tools.

This task is about adding a tool within the New Discussion and Reply Tools' toolbar that enables people to select from a set of special characters while composing topics and comments using these two tools

Requirements

Platforms: Desktop + ~~Mobile~~ (mobile will happen in T321630)
DiscussionTools Impacted: Reply Tool + New Topic Tool
Input modes: Visual + Source (Enable editing tools in source mode needs to be enabled)

Prototype

Updated 28 February 2021: https://patchdemo.wmflabs.org/wikis/86f00735362b0061ab7fdef1fd8c8a89/w/

Done

Step	Description	Status
1.	Editing engineering is going to re-base the patch @Esanders wrote in https://gerrit.wikimedia.org/r/667417	Done
2.	Editing engineering is going to create a patch demo for the re-based 667417	Done
3.	@nayoub is going to review the patch demo that "2." will create; paying special attention to how this new interface will look and function on mobile
4.	@ppelberg will add the `User-notice` tag to this task so that we can include the introduction the special characters toolbar as a "future change" in Tech/News
5.	Editing engineering will implement any changes that surface in "3." that we agree are worth making
6.	Editing QTE will conduct pre-deployment QA to verify everything is working as expected
7.	Change will ride train and be made avail. in all Reply and New Topic Tools (mobile + desktop)

Requests

Discussion at fr.wiki: https://w.wiki/4qEe
Discussion at mediawiki.org: Topic:Wptu33s4ye6vj03m
Request on mediawiki.org: Topic:X2oj786a8zsko63j
Request on huwiki: Wikipédia:Kocsmafal (műszaki)
Old ==New section== editor preferred due to lack of special characters: https://www.mediawiki.org/wiki/Topic:X2oj786a8zsko63j

Details

	Subject	Repo	Branch	Lines +/-
	Add 'specialCharacter' tool to toolbar	mediawiki/extensions/DiscussionTools	master	+4 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T282153 Expand the tools offered in DiscussionTools' toolbar
Resolved	• ppelberg	T249072 Add support in toolbar for special characters within DiscussionTools
Resolved	• ppelberg	T264146 Instrument the special characters toolbar
Open	None	T249074 Define approach for expanding DiscussionTools `visual` mode toolbar
Open	None	T257713 Add image upload to Reply tool's visual mode
Resolved	Esanders	T318720 Opening special characters toolbar blurs the document when using nullSelectionOnBlur (e.g. in DiscussionTools or VE standalone)

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

There seems to be a bug with the cursor placement on opening the dialog, but it looks like https://phabricator.wikimedia.org/T276164 (which @Esanders referenced) will fix that. Other than that, the dialog has parity with the experience on article/page editing.

With that fixed, I think this is ready for QA testing cc @Ryasmeen

• iamjessklein moved this task from Design Review to QA on the Editing-team (Kanban Board) board.Mar 2 2021, 6:26 PM

In T249072#6872502, @Esanders wrote:

"I wonder what we can do to avoid the collisions that ensue when trying to use the other text tools (linking, pinging, etc.) while the special characters interface is already open".

Having the inserter work with the link inspector is a larger project. It's an existing issue in VE, so I don't think it's critical here.

@Esanders: do you know if this issue already has a ticket? If so, are you able to link to it here?

• ppelberg added a subtask: T276258: Increase contrast of active state buttons in the special character dialog.Mar 3 2021, 5:29 PM

Is T276258 a blocker? I think it would be better to get the feature out as-is.

MBinder_WMF added a project: Editing QA.Mar 17 2021, 4:12 PM

• ppelberg removed a project: Editing QA.Mar 18 2021, 7:22 PM

• ppelberg moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.

These characters:

–
—
≤
≥

and a non-breaking space were requested by @Nthep at https://www.mediawiki.org/wiki/Topic:W563che155jf0uv0

In T249072#6880612, @Esanders wrote:

Is T276258 a blocker?

As I've been thinking about it, the blocker to the special characters toolbar being deployed is analyzing how the special character toolbar is being used (see: T266376) in VE, where it is already available.

@Esanders is there information that's leading you to think the special characters toolbar should be introduced before the analysis planned in T266376 happens?

• LZaman subscribed.Mar 31 2021, 4:21 PM

In T249072#6959166, @ppelberg wrote:

In T249072#6880612, @Esanders wrote:

Is T276258 a blocker?

As I've been thinking about it, the blocker to the special characters toolbar being deployed is analyzing how the special character toolbar is being used (see: T266376) in VE, where it is already available.

@Esanders is there information that's leading you to think the special characters toolbar should be introduced before the analysis planned in T266376 happens?

Today, @Esanders confirmed that in writing T249072#6880612 he was simply questioning whether T276258 should block the initial introduction of the special characters toolbar in the Reply and New Discussion Tools via T249072. Read: he was not meaning to question the deployment's dependence on T266376.

DECISION

We are not going to consider T276258 as a blocker to the special characters toolbar being released via T249072.
- Reason: per what was discussed during today's team conversation, we see T276258 as an optimization that can be made once people first have access to the functionality.

• ppelberg renamed this task from Replying v2.0: add support in toolbar for special characters to Add support in toolbar for special characters within DiscussionTools.Mar 31 2021, 7:28 PM

• ppelberg removed a subtask: T276258: Increase contrast of active state buttons in the special character dialog.

• ppelberg removed a project: Editing-team (Kanban Board).

• ppelberg updated the task description. (Show Details)

• LZaman unsubscribed.Mar 31 2021, 7:31 PM

• ppelberg removed a parent task: T249074: Define approach for expanding DiscussionTools `visual` mode toolbar.Mar 31 2021, 8:21 PM

• ppelberg added a subtask: T249074: Define approach for expanding DiscussionTools `visual` mode toolbar.

• ppelberg added a parent task: T282153: Expand the tools offered in DiscussionTools' toolbar.May 6 2021, 3:28 PM

Test wiki created on Patch Demo by ESanders (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/6db1b39e1a/w/

@iamjessklein, I like what see in the PatchDemo link.

• Whatamidoing-WMF mentioned this in T280390: Determine first set of Wikipedias where New Discussion Tool will be offered as opt-out.Jul 12 2021, 5:25 PM

• ppelberg removed a subtask: T266376: Analyze special characters toolbar usage.Aug 4 2021, 7:31 PM

I also don't think T249074 should be consider a blocker to this task either. That is a pretty significant piece of work and one that we may not have time to complete any time soon. Meanwhile we have a fair amount of space in the toolbar due to the limited tools available in the context of indented replies.

• ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Dec 9 2021, 5:05 PM

Esanders added a project: Editing-team (Kanban Board).Dec 18 2021, 12:41 AM

This comment was removed by Esanders.

Sakretsu subscribed.Jan 28 2022, 10:39 PM

• ppelberg updated the task description. (Show Details)Feb 14 2022, 8:58 PM

• ppelberg claimed this task.Mar 14 2022, 5:19 PM

Tacsipacsi added a project: Hungarian-Sites.Mar 15 2022, 12:39 AM

Tacsipacsi updated the task description. (Show Details)

Screenshots of the above patch:

• ppelberg moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Kanban Board) board.Apr 11 2022, 5:23 PM

@ppelberg This patch has not been reviewed/merged yet as it was assumed it was awaiting approval

Another request for this on enwiki: https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&diff=prev&oldid=1100413658

DLynch moved this task from Ready for Sign Off to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Aug 1 2022, 5:17 PM

• ppelberg edited projects, added Editing-team; removed Editing-team (Kanban Board).Aug 1 2022, 5:18 PM

• ppelberg moved this task from Untriaged to Upcoming on the Editing-team board.

matmarex added a project: TPP-Phase1.Aug 9 2022, 4:55 PM

matmarex moved this task from Tickets for Consideration to Reply Tool on the TPP-Phase1 board.Aug 9 2022, 4:58 PM

Tacsipacsi updated the task description. (Show Details)Sep 7 2022, 9:58 PM

VPuffetMichel removed a project: OWC2020 (Reply Tool Opt Out).Sep 8 2022, 3:50 PM

• ppelberg moved this task from Triaged to Existing Feature Improvements on the DiscussionTools board.Sep 10 2022, 12:31 AM

matej_suchanek awarded a token.Sep 11 2022, 7:04 AM

Tacsipacsi mentioned this in T318241: Allow anonymous users to use the legacy full-page editors for starting new topics.Sep 21 2022, 2:52 PM

• Whatamidoing-WMF updated the task description. (Show Details)Sep 26 2022, 6:23 PM

Per today's team meeting, we're going to prioritize doing what this task has asked for for some time: introducing the special characters button/interface within both the Reply and New Topic Tools' toolbars (desktop + mobile).

To do the above, we converged on the following:

Step	Description
1.	Editing engineering is going to re-base the patch @Esanders wrote in https://gerrit.wikimedia.org/r/667417
2.	Editing engineering is going to create a patch demo for the re-based 667417
3.	@nayoub is going to review the patch demo that "2." will create; paying special attention to how this new interface will look and function on mobile
4.	@ppelberg will add the `User-notice` tag to this task so that we can include the introduction the special characters toolbar as a "future change" in Tech/News
5.	Editing engineering will implement any changes that surface in "3." that we agree are worth making
6.	Editing QTE will conduct pre-deployment QA to verify everything is working as expected
7.	Change will ride train and be made avail. in all Reply and New Topic Tools (mobile + desktop)

• ppelberg removed • ppelberg as the assignee of this task.Oct 19 2022, 6:20 PM

• ppelberg updated the task description. (Show Details)

• ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team.

• ppelberg moved this task from Blocked / Needs More Work to Incoming on the Editing-team (Kanban Board) board.

Quiddity awarded a token.Oct 19 2022, 9:32 PM

Esanders added a subtask: T318720: Opening special characters toolbar blurs the document when using nullSelectionOnBlur (e.g. in DiscussionTools or VE standalone).Oct 20 2022, 12:41 PM

Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/6bd624a6b7/w

https://patchdemo.wmflabs.org/wikis/6bd624a6b7/wiki/Talk:DiscussionTools

Pasztilla unsubscribed.Oct 20 2022, 1:23 PM

Esanders moved this task from Code Review to Design Review on the Editing-team (Kanban Board) board.Oct 20 2022, 9:24 PM

Esanders updated the task description. (Show Details)

Re: mobile. I don't think we've ever made this tool available on mobile, nor do I think there is the same need there as localised IME's are almost universally available on mobile.

Currently this patch does not make it available on mobile, and I think it should stay that way for now.

Change 667417 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Add 'specialCharacter' tool to toolbar

https://gerrit.wikimedia.org/r/667417

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Oct 25 2022, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 25 2022, 4:30 PM

• ppelberg closed subtask T318720: Opening special characters toolbar blurs the document when using nullSelectionOnBlur (e.g. in DiscussionTools or VE standalone) as Resolved.Oct 25 2022, 4:51 PM

In T249072#8335376, @Esanders wrote:

Re: mobile. I don't think we've ever made this tool available on mobile, nor do I think there is the same need there as localised IME's are almost universally available on mobile.

Currently this patch does not make it available on mobile, and I think it should stay that way for now.

Per the conversation we had offline today, we are going to do as Ed is describing above: limit the introduction of the special characters toolbar to desktop to start.

Thinking...

93% of all mobile edit attempts are made using the following operating systems: Android (41.2%), Windows (38.2%), iOS (14.2%) [i]
We assume that each of the operating systems above offer people the virtual keyboards and keys they need to contribute to Wikipedia in ways they expect

In line with the above, I've filed T321630 as a place for us to accumulate new information that could cause us to revise the decision above and the "Thinking" that led to it.

i. https://superset.wikimedia.org/r/2017

In reply-tool, looks like this is added now

However, can the placement be adjusted? Having the user-selector be last has been very helpful, and makes targeting it easy - can the insert tool be moved one to the left?

In T249072#8369313, @Xaosflux wrote:

In reply-tool, looks like this is added now

However, can the placement be adjusted? Having the user-selector be last has been very helpful, and makes targeting it easy - can the insert tool be moved one to the left?

Great spot, @Xaosflux. I think we should make the change you are describing. Here is a ticket for making that change: T322455.

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/6bd624a6b7/w/~~

I think a large use of “special characters” is for people inserting ones that are not in their native language. I don’t want to enable Greek IME just to type β. And good luck finding → on any keyboard.

In T249072#8383997, @Pelagic wrote:

I think a large use of “special characters” is for people inserting ones that are not in their native language. I don’t want to enable Greek IME just to type β. And good luck finding → on any keyboard.

@Pelagic, this use case is helpful to know – thank you for sharing it. I think you'll be pleased to know that the special characters toolbar is now available within the desktop Reply and New Topic Tools at all projects.

In T249072#8384017, @ppelberg wrote:

… pleased to know … now available within the desktop … Tools …

Thanks, Peter. Catching up on recent Tech News is what brought me here. I think the use case applies to mobile as well as desktop. It would be great if some buttons could be conditionally shown where there is sufficient width (tablet, or phone in landscape orientation), but that adds complexity.

In T249072#8384078, @Pelagic wrote:

In T249072#8384017, @ppelberg wrote:

… pleased to know … now available within the desktop … Tools …

Thanks, Peter. Catching up on recent Tech News is what brought me here.

Ah, okay!

I think the use case applies to mobile as well as desktop. It would be great if some buttons could be conditionally shown where there is sufficient width (tablet, or phone in landscape orientation), but that adds complexity.

Understood. We're using T321630 to track the work/consider of offering the special characters toolbar on mobile.

I'm going to make sure the comment you posted above is reflected on T321630 as well.

I'm moving this to QA seeing as how this has been out in production for some time now.

• ppelberg moved this task from Design Review to QA on the Editing-team (Kanban Board) board.Jan 11 2023, 12:04 AM

• ppelberg added a project: Editing QA.

• ppelberg updated the task description. (Show Details)

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Feb 8 2023, 12:06 AM

Ryasmeen edited projects, added Verified; removed Editing QA.

• ppelberg closed this task as Resolved.Feb 13 2023, 4:43 PM

• ppelberg claimed this task.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 13 2023, 4:43 PM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/6db1b39e1a/w/~~

Test wiki on Patch demo by PPelberg (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/86f00735362b0061ab7fdef1fd8c8a89/w/~~

	F35627623: Screen Shot 2022-10-25 at 3.16.54 PM.png
	Oct 25 2022, 10:21 PM

	F32364019: Screen Shot 2020-09-25 at 4.57.14 PM.png
	Sep 25 2020, 11:59 PM

	F35705695: image.png
	Nov 4 2022, 9:58 AM

	F35007081: image.png
	Mar 15 2022, 1:59 PM

	F35007083: image.png
	Mar 15 2022, 1:59 PM

Add support in toolbar for special characters within DiscussionToolsClosed, ResolvedPublicActions

Description

Requirements

Prototype

Done

Requests

Details

Related ObjectsSearch...

Event Timeline

Add support in toolbar for special characters within DiscussionTools
Closed, ResolvedPublic
Actions

Related Objects
Search...