Page MenuHomePhabricator
Create Task
Maniphest T249112

Section headings no longer in edit summary
Closed, ResolvedPublic
Actions

Description

When I edit a specific section in an article, the section heading no longer appears in the edit summary. This only happens when using VE and not when using source editing. I have noticed this on both Google Chrome and Microsoft Edge.

Details

SubjectRepoBranchLines +/-
Fix issues with treating section "numbers" as integersmediawiki/extensions/VisualEditorwmf/1.35.0-wmf.26+16 -15
Fix issues with treating section "numbers" as integersmediawiki/extensions/VisualEditormaster+16 -15
Customize query in gerrit

Related Objects

Event Timeline

Presidentman created this task.Apr 1 2020, 2:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2020, 2:13 PM
gerritbot added a comment.Apr 1 2020, 5:26 PM

Change 585029 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Fix issues with treating section "numbers" as integers

https://gerrit.wikimedia.org/r/585029

gerritbot added a project: Patch-For-Review.Apr 1 2020, 5:26 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Apr 1 2020, 5:26 PM
matmarex added projects: Editing-team (Q3 2019-2020 Kanban Board), Regression.
matmarex moved this task from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.
matmarex subscribed.

Caused by rEVEDe2cb9ce93ea5: Remove incorrect handling for 'T-' prefix in section numbers (T246164)

gerritbot added a comment.Apr 1 2020, 8:57 PM

Change 585029 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix issues with treating section "numbers" as integers

https://gerrit.wikimedia.org/r/585029

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 1 2020, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 1 2020, 9:10 PM
gerritbot added a comment.Apr 2 2020, 6:05 PM

Change 585554 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.26] Fix issues with treating section "numbers" as integers

https://gerrit.wikimedia.org/r/585554

gerritbot added a project: Patch-For-Review.Apr 2 2020, 6:05 PM
gerritbot added a comment.Apr 2 2020, 6:14 PM

Change 585554 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.35.0-wmf.26] Fix issues with treating section "numbers" as integers

https://gerrit.wikimedia.org/r/585554

Stashbot mentioned this in T248795: Section 0 (lead) uses first line of wikitext as section title in NWE summary.Apr 2 2020, 6:22 PM
Stashbot mentioned this in T248968: Editor jumps on top of the page when using VisualEditor.

Mentioned in SAL (#wikimedia-operations) [2020-04-02T18:22:08Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.26/extensions/VisualEditor/modules/ve-mw: SWAT: rEVED94ded03cd479: Fix issues with treating section "numbers" as integers (T248795; T248968; T249112) (duration: 01m 10s)

matmarex edited projects, added Editing QA, MW-1.35-notes (1.35.0-wmf.26; 2020-03-31); removed Patch-For-Review, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 2 2020, 6:50 PM
matmarex moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.

The bug affects wmf.25 and wmf.26. I only backported it to wmf.26, because the patch did not cherry-pick cleanly to wmf.25, and I didn't want to make last-minute changes to it. wmf.26 should be deployed everywhere in a few hours.

Presidentman added a comment.Apr 2 2020, 7:27 PM

Just worked fine for me on en-wikipedia.

matmarex added a comment.Apr 2 2020, 7:51 PM

Indeed wmf.26 is apparently already deployed, as of 45 minutes ago: T247773#6024043. Thanks for checking!

Ryasmeen edited projects, added Verified; removed Editing QA.Apr 9 2020, 11:22 PM
matmarex moved this task from QA to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.Apr 12 2020, 6:06 PM
• ppelberg closed this task as Resolved.May 1 2020, 1:10 AM
• ppelberg claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 1 2020, 1:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL