Implement the "reload" functionality
Closed, ResolvedPublic
Actions

Description

options we discussed - actual implementation up to the dev who researched further:

re-dispatch app from init
resetting state, maybe emptying errors and doing initBridge again

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/Wikibase	master	+13 -9	bridge: only emit one type of events from App
mediawiki/extensions/Wikibase	master	+144 -33	bridge: implement ability to relaunch
mediawiki/extensions/Wikibase	master	+21 -7	bridge: Redispatch bridge on reload event
mediawiki/extensions/Wikibase	master	+14 -5	bridge: implement ability to reload (via store)

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T228066 Step 1: Error States of Data-Bridge [Tracking] (impact: medium)
Resolved	Charlie_WMDE	T241126 Step 1: Improved generic error screen (impact: high)
Resolved	Lucas_Werkmeister_WMDE	T249118 Implement the "reload" functionality

Event Timeline

Pablo-WMDE created this task.Apr 1 2020, 3:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2020, 3:07 PM

Pablo-WMDE mentioned this in T249124: Wire up reload button and reloading logic.Apr 1 2020, 3:09 PM

Pablo-WMDE edited projects, added Wikidata-Bridge-Sprint-17; removed Wikidata-Bridge.Apr 1 2020, 3:41 PM

Michael claimed this task.Apr 1 2020, 4:40 PM

Michael moved this task from To do to Doing on the Wikidata-Bridge-Sprint-17 board.

Restricted Application added a project: User-Michael. · View Herald TranscriptApr 1 2020, 4:40 PM

Change 585282 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Redispatch bridge on reload event

https://gerrit.wikimedia.org/r/585282

gerritbot added a project: Patch-For-Review.Apr 1 2020, 5:30 PM

Michael moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-17 board.Apr 1 2020, 5:32 PM

Change 585289 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: implement ability to reload (via store)

https://gerrit.wikimedia.org/r/585289

Change 585459 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: implement ability to reload (via store)

https://gerrit.wikimedia.org/r/585459

Michael removed Michael as the assignee of this task.Apr 2 2020, 3:56 PM

Michael removed a project: User-Michael.

Michael added a subscriber: Michael.

Michael moved this task from Peer Review to To do on the Wikidata-Bridge-Sprint-17 board.Apr 3 2020, 5:14 PM

Change 585289 abandoned by Pablo Grass (WMDE):
bridge: implement ability to reload (via store)

Reason:
This was a PoC as alternative to I632631fb209acb41af7041e01e0a8c393b4af1fd which spun Ibe1291c553a3495a203706477c1af1ff0989797e (which goes a bit further but also adds tests, ... that'd be needed no matter what)

https://gerrit.wikimedia.org/r/585289

Change 585282 abandoned by Michael Große:
bridge: Redispatch bridge on reload event

Reason:
Approach in Ibe1291c553a3495a203706477c1af1ff0989797e was preferred by UX

https://gerrit.wikimedia.org/r/585282

Lucas_Werkmeister_WMDE claimed this task.Apr 6 2020, 5:45 PM

Lucas_Werkmeister_WMDE moved this task from To do to Peer Review on the Wikidata-Bridge-Sprint-17 board.

darthmon_wmde added a project: Wikidata-Bridge-Sprint-18.Apr 8 2020, 11:18 AM

darthmon_wmde moved this task from To do to Peer Review on the Wikidata-Bridge-Sprint-18 board.

Change 585459 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: implement ability to relaunch

https://gerrit.wikimedia.org/r/585459

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 8 2020, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 8 2020, 5:10 PM

Pablo-WMDE closed this task as Resolved.Apr 9 2020, 8:40 AM

Pablo-WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-18 board.

Change 587552 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: only emit one type of events from App

https://gerrit.wikimedia.org/r/587552

gerritbot added a project: Patch-For-Review.Apr 9 2020, 8:40 AM

Change 587552 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: only emit one type of events from App

https://gerrit.wikimedia.org/r/587552

Maintenance_bot removed a project: Patch-For-Review.Apr 9 2020, 4:10 PM