Page MenuHomePhabricator
Create Task
Maniphest T249124

Wire up reload button and reloading logic
Closed, ResolvedPublic
Actions

Description

  • the reload button added to the ErrorUnknown component (T249123) should trigger the reloading logic added earlier (T249118)
    • when emitting the event from ErrorUnknown be sure to document this fact in storybook (currently its docs are completely empty)
  • browser tests

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+50 -10bridge: selenium: assert loading is shown at first
mediawiki/extensions/Wikibasemaster+105 -10bridge: relaunch bridge from ErrorUnknown
mediawiki/extensions/Wikibasemaster+20 -1bridge: selenium: distinguish between error types
mediawiki/extensions/Wikibasemaster+30 -24bridge: selenium: move error handling test to dedicated spec
Customize query in gerrit

Related Objects
Search...

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2020, 3:09 PM
Pablo-WMDE updated the task description. (Show Details)Apr 9 2020, 10:49 AM
Pablo-WMDE claimed this task.Apr 9 2020, 12:05 PM
Pablo-WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-18 board.
gerritbot added a comment.Apr 9 2020, 2:15 PM

Change 587758 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: relaunch bridge from ErrorUnknown

https://gerrit.wikimedia.org/r/587758

gerritbot added a comment.Apr 22 2020, 1:31 PM

Change 591863 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: selenium: move error handling test to dedicated spec

https://gerrit.wikimedia.org/r/591863

gerritbot added a comment.Apr 22 2020, 1:40 PM

Change 591869 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: selenium: assert loading is shown at first

https://gerrit.wikimedia.org/r/591869

gerritbot added a comment.Apr 23 2020, 10:20 AM

Change 592255 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: selenium: distinguish between error types

https://gerrit.wikimedia.org/r/592255

gerritbot added a comment.Apr 23 2020, 11:47 AM

Change 591863 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: selenium: move error handling test to dedicated spec

https://gerrit.wikimedia.org/r/591863

gerritbot added a comment.Apr 23 2020, 3:05 PM

Change 592255 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: selenium: distinguish between error types

https://gerrit.wikimedia.org/r/592255

gerritbot added a comment.Apr 28 2020, 9:31 AM

Change 587758 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: relaunch bridge from ErrorUnknown

https://gerrit.wikimedia.org/r/587758

Pablo-WMDE closed this task as Resolved.Apr 28 2020, 10:09 AM
Pablo-WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-18 board.
gerritbot added a comment.May 7 2020, 9:50 AM

Change 591869 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: selenium: assert loading is shown at first

https://gerrit.wikimedia.org/r/591869

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL