Page MenuHomePhabricator
Create Task
Maniphest T249172

Error from line 99 of "PF_CreateProperty.php": Call to a member function getDatatypeLabels() on null
Closed, ResolvedPublic
Actions

Description

Setup

  • MediaWiki 1.34.1 (d29905e)
  • PHP 7.2.24-0ubuntu0.18.04.3 (apache2handler)
  • MariaDB 10.1.44-MariaDB-0ubuntu0.18.04.1
  • Semantic MediaWiki 3.2.0-alpha (7f7e38c) 17:44, 29 March 2020
  • PageForms 4.8 (c20df12) 15:14, 27 March 2020

Issue

[cf783eb6b53258f16edd6fa7] /wiki/Sp%C3%A9cial:CreateProperty Error from line 99 of /../w/extensions/PageForms/specials/PF_CreateProperty.php: Call to a member function getDatatypeLabels() on null

Backtrace

#0 /../w/extensions/PageForms/specials/PF_CreateProperty.php(22): PFCreateProperty->printCreatePropertyForm(NULL)
#1 /../w/includes/specialpage/SpecialPage.php(575): PFCreateProperty->execute(NULL)
#2 /../w/includes/specialpage/SpecialPageFactory.php(611): SpecialPage->run(NULL)
#3 /../w/includes/MediaWiki.php(296): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#4 /../w/includes/MediaWiki.php(900): MediaWiki->performRequest()
#5 /../w/includes/MediaWiki.php(527): MediaWiki->main()
#6 /../w/index.php(44): MediaWiki->run()
#7 {main}

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Use correct function to check availability of smwfContLangBluedreamer1mediawiki/extensions/PageFormsmaster+1 -1
Use smwfContLang() for SMW 3.2+Yaron Korenmediawiki/extensions/PageFormsmaster+18 -13
Customize query in gerrit

Related Objects

Event Timeline

Kghbln created this task.Apr 1 2020, 8:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2020, 8:59 PM
JeroenDeDauw subscribed.Apr 9 2020, 6:47 PM

Also seeing this issue

Kghbln mentioned this in T246579: `smwgContLang` removed from Semantic MediaWiki codebase.Apr 11 2020, 5:52 PM

Due to T246579

Nikerabbit added a project: affects-translatewiki.net.Sep 15 2020, 10:29 AM
Nikerabbit subscribed.

This is now causing errors on translatewiki.net, since we updated to SMW 3.2.0.

Yaron_Koren added a comment.Sep 15 2020, 12:49 PM

I'm not sure I can fix this, since I don't have access to a development environment running a recent version of SMW. But if anyone submits a patch to fix this, I'll be glad to check it in.

KBailly subscribed.Sep 16 2020, 12:54 PM

You may fix the bug by editing the effected files that are named in the error msg (e.g. [...]/extensions/PageForms/specials/PF_CreateClass.php)

At the line, stated in the error message there should be a code like this:

$possibleTypes = $smwgContLang->getDatatypeLabels();

the variable $smwgContLang is no longer available (thats why the error msg tells that the function "getDatatypeLabels" is called on null). change the code as following:

$possibleTypes = smwfContLang()->getDatatypeLabels();

This should get PageForms special pages back to work. (see https://phabricator.wikimedia.org/T246579)

gerritbot added a comment.Sep 16 2020, 4:53 PM

Change 627794 had a related patch set uploaded (by Yaron Koren; owner: Yaron Koren):
[mediawiki/extensions/PageForms@master] Use smwfContLang() for SMW 3.2+

https://gerrit.wikimedia.org/r/627794

gerritbot added a project: Patch-For-Review.Sep 16 2020, 4:53 PM
gerritbot added a comment.Sep 16 2020, 5:35 PM

Change 627794 merged by jenkins-bot:
[mediawiki/extensions/PageForms@master] Use smwfContLang() for SMW 3.2+

https://gerrit.wikimedia.org/r/627794

Yaron_Koren added a comment.Sep 16 2020, 5:39 PM

@KBailly - thanks for the suggested fix! I just checked in a fix based on this, which should hopefully work across different SMW versions. I haven't tested it, but hopefully things are working better now.

Yaron_Koren mentioned this in rEPFMc41128bcbd89: Use smwfContLang() for SMW 3.2+.Sep 16 2020, 5:40 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 16 2020, 6:10 PM
Yaron_Koren merged a task: T263439: Internal error /index.php?title=Special:CreateClass Error from line 219 of /home/mediawiki/mediawiki-1.34.2/extensions/PageForms/specials/PF_CreateClass.php: Call to a member function getDatatypeLabels() on null.Sep 21 2020, 1:36 PM
Yaron_Koren added a subscriber: Bluedreamer1.
Bluedreamer1 added a comment.Sep 21 2020, 2:00 PM

I tried applying the gerrit to the code on my machine and it doesn't work, it doesn't like the PF_Utils change.

[21-Sep-2020 13:58:09 UTC] PHP Warning:  method_exists() expects exactly 2 parameters, 1 given in /home/mediawiki/mediawiki-1.34.2/extensions/PageForms/includes/PF_Utils.php on line 29
[21-Sep-2020 13:58:09 UTC] PHP Stack trace:
[21-Sep-2020 13:58:09 UTC] PHP   1. {main}() /home/mediawiki/mediawiki-1.34.2/index.php:0
[21-Sep-2020 13:58:09 UTC] PHP   2. MediaWiki->run() /home/mediawiki/mediawiki-1.34.2/index.php:44
[21-Sep-2020 13:58:09 UTC] PHP   3. MediaWiki->main() /home/mediawiki/mediawiki-1.34.2/includes/MediaWiki.php:527
[21-Sep-2020 13:58:09 UTC] PHP   4. MediaWiki->performRequest() /home/mediawiki/mediawiki-1.34.2/includes/MediaWiki.php:900
[21-Sep-2020 13:58:09 UTC] PHP   5. MediaWiki\Special\SpecialPageFactory->executePath() /home/mediawiki/mediawiki-1.34.2/includes/MediaWiki.php:296
[21-Sep-2020 13:58:09 UTC] PHP   6. PFCreateClass->run() /home/mediawiki/mediawiki-1.34.2/includes/specialpage/SpecialPageFactory.php:611
[21-Sep-2020 13:58:09 UTC] PHP   7. PFCreateClass->execute() /home/mediawiki/mediawiki-1.34.2/includes/specialpage/SpecialPage.php:575
[21-Sep-2020 13:58:09 UTC] PHP   8. PFUtils::getSMWContLang() /home/mediawiki/mediawiki-1.34.2/extensions/PageForms/specials/PF_CreateClass.php:218
[21-Sep-2020 13:58:09 UTC] PHP   9. method_exists() /home/mediawiki/mediawiki-1.34.2/extensions/PageForms/includes/PF_Utils.php:29

Which still gives the error now in browser

[X2ixcd7jem9@DQnya3pkGwAAAM8] /index.php?title=Special:CreateClass Error from line 218 of /home/mediawiki/mediawiki-1.34.2/extensions/PageForms/specials/PF_CreateClass.php: Call to a member function getDatatypeLabels() on null

Backtrace:

#0 /home/mediawiki/mediawiki-1.34.2/includes/specialpage/SpecialPage.php(575): PFCreateClass->execute()
#1 /home/mediawiki/mediawiki-1.34.2/includes/specialpage/SpecialPageFactory.php(611): SpecialPage->run()
#2 /home/mediawiki/mediawiki-1.34.2/includes/MediaWiki.php(296): MediaWiki\Special\SpecialPageFactory->executePath()
#3 /home/mediawiki/mediawiki-1.34.2/includes/MediaWiki.php(900): MediaWiki->performRequest()
#4 /home/mediawiki/mediawiki-1.34.2/includes/MediaWiki.php(527): MediaWiki->main()
#5 /home/mediawiki/mediawiki-1.34.2/index.php(44): MediaWiki->run()
#6 {main}
Bluedreamer1 added a comment.Sep 21 2020, 2:07 PM

I don't have gerrit setup at the moment - but its a 1 liner

[mediawiki@aardvark PageForms]$ git diff
diff --git a/includes/PF_Utils.php b/includes/PF_Utils.php
index 015d3b3c..517ea8a1 100644
--- a/includes/PF_Utils.php
+++ b/includes/PF_Utils.php
@@ -26,7 +26,7 @@ class PFUtils {
        }

        public static function getSMWContLang() {
-               if ( method_exists( 'smwfContLang' ) ) {
+               if ( function_exists( 'smwfContLang' ) ) {
                        // SMW 3.2+
                        return smwfContLang();
                } else {
gerritbot added a comment.Sep 21 2020, 2:15 PM

Change 628837 had a related patch set uploaded (by Bluedreamer1; owner: Bluedreamer1):
[mediawiki/extensions/PageForms@master] Additional code for T249172

https://gerrit.wikimedia.org/r/628837

gerritbot added a project: Patch-For-Review.Sep 21 2020, 2:15 PM
gerritbot added a comment.Sep 21 2020, 2:33 PM

Change 628837 had a related patch set uploaded (by Nikerabbit; owner: Bluedreamer1):
[mediawiki/extensions/PageForms@master] Use correct function to check availability of smwfContLang

https://gerrit.wikimedia.org/r/628837

gerritbot added a comment.Sep 21 2020, 3:18 PM

Change 628837 merged by jenkins-bot:
[mediawiki/extensions/PageForms@master] Use correct function to check availability of smwfContLang

https://gerrit.wikimedia.org/r/628837

Nikerabbit mentioned this in rEPFMae21fb1be655: Use correct function to check availability of smwfContLang.Sep 21 2020, 4:18 PM
Yaron_Koren added a comment.Sep 21 2020, 6:37 PM

Sorry about that, and thanks for the fix! And welcome to the world of MediaWiki development!

Bluedreamer1 added a comment.Sep 21 2020, 7:17 PM

Thanks for the welcome :-)

Just glad it was simple enough for me to fix and that I can contribute a tiny bit back to the community

Kghbln closed this task as Resolved.Sep 26 2020, 6:37 PM
Kghbln assigned this task to Bluedreamer1.

I guess this one was resolved. Thanks a bunch.

Kghbln removed a project: Patch-For-Review.Sep 26 2020, 6:37 PM
Ivanhercaz subscribed.Sep 30 2020, 9:16 PM
Kghbln added a comment.Apr 23 2021, 5:56 PM

Huu, I am afraid this issue is still not resolved. Reported on mediawiki.org. I just tried myself for MW 1.35, PF 5.2 and SMW 3.2 with the following error:

[d0fb41d4c4e843317680c34e] /wiki/Sp%C3%A9cial:CreateClass Error from line 320 of /../w/extensions/PageForms/specials/PF_CreateClass.php: Call to undefined method PFCreateClass::printPropertiesComboBox()

Backtrace:

#0 /../w/extensions/PageForms/specials/PF_CreateClass.php(34): PFCreateClass->printCreateClassForm(NULL)
#1 /../w/includes/specialpage/SpecialPage.php(600): PFCreateClass->execute(NULL)
#2 /../w/includes/specialpage/SpecialPageFactory.php(635): SpecialPage->run(NULL)
#3 /../w/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#4 /../w/includes/MediaWiki.php(940): MediaWiki->performRequest()
#5 /../w/includes/MediaWiki.php(543): MediaWiki->main()
#6 /../w/index.php(53): MediaWiki->run()
#7 /../w/index.php(46): wfIndexMain()
#8 {main}
Kghbln reopened this task as Open.Apr 23 2021, 5:57 PM
Kghbln closed this task as Resolved.Apr 23 2021, 6:02 PM

Sorry for the noise. I have a different issue now tracked with T280994

BertrandGorge subscribed.EditedApr 26 2021, 9:38 AM

Hello, I just reproduced the bug on a MW 1_35.2 :

MediaWiki 1.35.2 (2e18b74)
Semantic MediaWiki 3.2.3
Page Forms 4.9.4 (945152c)

[ea4eb9148ddef4e4a8b0a38e] /wiki/Sp%C3%A9cial:CreateClass Error from line 219 of /var/www/html/extensions/PageForms/specials/PF_CreateClass.php: Call to a member function getDatatypeLabels() on null

I installed Page Forms using git, on branch 1_35.

I also tried to use branch master, but then I have something similar to https://phabricator.wikimedia.org/T249172 :

[a36561ec0f403f0bee155a95] /wiki/Sp%C3%A9cial:CreateClass Error from line 320 of /var/www/html/extensions/PageForms/specials/PF_CreateClass.php: Call to undefined method PFCreateClass::printPropertiesComboBox()

Nikerabbit added a comment.Apr 26 2021, 10:25 AM

You can use the latest release 5.2. https://github.com/wikimedia/mediawiki-extensions-PageForms/releases

BertrandGorge added a comment.Apr 26 2021, 12:00 PM

Hello @Nikerabbit

As I said, I tried with the master (version 5.2) but it then fails elsewhere. I finally managed to get things working by backporting the two commits in the branch REL1_35 : https://github.com/wikimedia/mediawiki-extensions-PageForms/search?q=smwfContLang&type=commits - but only on local for the moment.

Mdyug mentioned this in T290713: Page Forms error when saving " CreateProperty " .Sep 10 2021, 6:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits