Page MenuHomePhabricator

New video player does not leave enough space in gallery
Open, Needs TriagePublic


In this section, I added a video:

If I'm not activating the new videoplayer, it looks like this:

If I'm activating it, it looks like this:

As you can see in the second screenshot there is no space between the video, and the foto on the right. This should not happen.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2020, 10:07 AM
brion added a subscriber: brion.Apr 2 2020, 6:02 PM

Can't reproduce in Chrome, but can in Firefox. Something seems wonky with the gallery layout in Firefox specifically.

brion added a comment.Apr 2 2020, 6:11 PM

Looks like there's two things going on:

  1. the video preview doesn't resize to fit the gallery container (it's an actual <video> with a poster image under the lid, not an <img>, so styles might not be applying to it that need to be); this usually adds extra space around the image
  2. in Firefox, the video sometimes overflows the available space, causing insufficient space around the image as in the screenshot

Fixing 1) should fix 2) as a side effect, I think.

brion renamed this task from New video player does not leave enough space to New video player does not leave enough space in gallery.Apr 2 2020, 6:14 PM
brion moved this task from Backlog to UI/UX Regressions on the VideoJS player board.