CU 2.0: Add option to add IP ranges to search
Open, LowPublic
Actions

Assigned To

None

Authored By

	• Niharika
	Apr 2 2020, 4:56 PM

Description

User story

As a CheckUser, I often need to look up the information about users from an entire IP range rather than just an IP itself.

We heard this from multiple users on the CheckUser project talk page.

Mocks


Split the Show X users on this IP button	Clicking the button with open a dropdown	The dropdown has options for including all IPs on /16, /32, /64 ranges (any we can't do?)

Acceptance criteria

Split the Show X users on this IP button
Add dropdown for
- Include /16 range and Include /24 range for IPv4 IPs
- Include /32 range and Include /64 range for IPv6 IPs
Clicking the dropdown adds all the users in the /X range to the table
Clicking on the button without clicking on the dropdown works as normal -- only the users from the exact same IP are added to the table.

Details

	Subject	Repo	Branch	Lines +/-
	SpecialInvestigate: Add additional users on IPv6 /64 range	mediawiki/extensions/CheckUser	master	+5 -1

Customize query in gerrit

Event Timeline

• Niharika triaged this task as Medium priority.Apr 2 2020, 4:56 PM

• Niharika created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2020, 4:56 PM

• Niharika added a project: CheckUser.Apr 2 2020, 4:56 PM

• Niharika updated the task description. (Show Details)Apr 2 2020, 5:25 PM

@Tchanders This ticket was also dependent on the Performance investigation you did. Do you have any recommendations about this task?

@Niharika I think the main concern would be making sure we don't go over the limit that we set for the number of targets. (So if our limit is 10, and the user already entered 10 targets in the initial form, these buttons should be disabled, or they could add unlimited targets.) As long as we can keep within that limit, this wouldn't be any worse than adding the range in the initial form.

I notice this would also need re-designing now that we don't have the blue button any more.

• Niharika moved this task from Triage/To be Estimated to Design on the Anti-Harassment board.May 21 2020, 4:46 PM

In T249239#6148705, @Tchanders wrote:

So if our limit is 10, and the user already entered 10 targets in the initial form, these buttons should be disabled, or they could add unlimited targets.)

A technical clarification: we should put the limit on the form processing as well because the button being disabled doesn't prevent additional targets from being added. :)

Some changes coming up on this task. We've changed the interface quite a bit here, and I am not sure if a nested menu would make things too complicated.

Add dropdown for
Include /16 range and Include /24 range for IPv4 IPs
Include /32 range and Include /64 range for IPv6 IPs

Based on the usability tests we now want a more fine-grained control here. @Niharika, what is the range we want to provide here? 1 to 24 for IPv4, and 1 to 64 for IPv6?

In T249239#6200423, @Prtksxna wrote:

Some changes coming up on this task. We've changed the interface quite a bit here, and I am not sure if a nested menu would make things too complicated.

Add dropdown for
Include /16 range and Include /24 range for IPv4 IPs
Include /32 range and Include /64 range for IPv6 IPs

Based on the usability tests we now want a more fine-grained control here. @Niharika, what is the range we want to provide here? 1 to 24 for IPv4, and 1 to 64 for IPv6?

I'm not 100% sure I understand this. A range with less than 16 bits is very broad and unlikely useful in my opinion. Can you expand on the usability test and on what do you mean by "fine-graned control"?
I would think that the dropdown is fine as a shortcut for the range target (unless some CheckUsers have said otherwise)

In T249239#6148705, @Tchanders wrote:

@Niharika I think the main concern would be making sure we don't go over the limit that we set for the number of targets. (So if our limit is 10, and the user already entered 10 targets in the initial form, these buttons should be disabled, or they could add unlimited targets.) As long as we can keep within that limit, this wouldn't be any worse than adding the range in the initial form.

I notice this would also need re-designing now that we don't have the blue button any more.

This is a good point, it might be worth displaying a tooltip or message somewhere explaining why the buttons are being disabled if they hit the limit.

• Prtksxna added a project: Design.Jun 25 2020, 2:37 AM

DannyS712 awarded a token.Nov 18 2020, 4:52 PM

• Prtksxna lowered the priority of this task from Medium to Low.Jan 11 2021, 4:09 AM

dbarratt unsubscribed.Jan 11 2021, 4:15 AM

Dreamy_Jazz moved this task from General / Unsorted to Investigate on the CheckUser board.Jul 16 2022, 11:58 PM

Blablubbs subscribed.Jan 6 2023, 11:59 PM

Change 937163 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] SpecialInvestigate: Add additional users on IPv6 /64 range

https://gerrit.wikimedia.org/r/937163

gerritbot added a project: Patch-For-Review.Jul 11 2023, 5:59 PM

Change 937163 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] SpecialInvestigate: Add additional users on IPv6 /64 range