Page MenuHomePhabricator

Loading indicator renders in the top left corner instead of centre
Closed, ResolvedPublic

Description

Seen in Firefox 74 at https://test2.wikipedia.org/wiki/Male_user:TheDJ

Maybe it’s fixed already, but I couldn’t find a task.

image.png (728×1 px, 638 KB)

Event Timeline

Ah, I see what's going on... the first loading indicator is running during the time that we load up OOUI etc, before we have a dialog, so it's just sitting on the page globally instead of being anchored anywhere in specific.

I think it should probably get moved to over the clicked video, or something, though I'm not 100% sure how to anchor this well for small or audio widgets.

I've seen this and I considered this a feature, not a bug, because it allows the user to see the video capture better. Anecdotic evidence from a discussion on ro.wp seem to suggest I'm not the only one. Seeing the videJs player vs the previous one, people reacted with "ah, that's slightly better [for infoboxes]"

I've seen this and I considered this a feature, not a bug, because it allows the user to see the video capture better. Anecdotic evidence from a discussion on ro.wp seem to suggest I'm not the only one. Seeing the videJs player vs the previous one, people reacted with "ah, that's slightly better [for infoboxes]"

You are mistaking the notion of this task, this task about the loading indicator displaying in the random place, not about the video player being displayed in a modal window. Your feedback is more apt in T246035: Videojs player for audio opens a dialog to support subtitles, which is unexpected.

Change 748378 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Fix the progressbar when loading videoJs

https://gerrit.wikimedia.org/r/748378

Change 748378 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Fix the progressbar when loading videoJs

https://gerrit.wikimedia.org/r/748378