Copied from T246294.
Highlighting in Preliminary check should only be made on the basis of date, ignoring the time.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| PreliminaryCheckPager: Highlight registration results by date | mediawiki/extensions/CheckUser | master | +14 -3 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Niharika | T246294 [Epic] Iterate on the design of highlighting for Special:Investigate | |||
| Resolved | Tchanders | T249253 Highlight in Preliminary check on the basis of date [Small] |
Event Timeline
Comment Actions
Change 587234 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] PreliminaryCheckPager: Highlight registration results by date
Comment Actions
Change 587234 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] PreliminaryCheckPager: Highlight registration results by date
Comment Actions
Same dates are highlighted in the preliminary check table, ignoring time. It can be pinned like other highlighting.
The date is based on the logged in user's timezone, so highlighting might be different for different users (i.e. the date might be different in different timezones).
Tested on Chrome 81 and Safari 12.1.
Comment Actions
The date is based on the logged in user's timezone, so highlighting might be different for different users (i.e. the date might be different in different timezones).
@Prtksxna I think we didn't explicitly discuss this. I was assuming dates will be in UTC. Do you think we need to make it explicit that the dates are in the user's timezone?
Comment Actions
I believe it uses whatever is in the user's preferences: https://test.wikipedia.org/wiki/Special:Preferences#mw-prefsection-rendering
Comment Actions
Thanks @dbarratt, this makes sense. It is a generic setting and should be applied everywhere it makes sense.