Page MenuHomePhabricator

Highlight in Preliminary check on the basis of date [Small]
Closed, ResolvedPublic

Description

Copied from T246294.

Highlighting in Preliminary check should only be made on the basis of date, ignoring the time.

Event Timeline

Niharika renamed this task from Highlight in Preliminary check on the basis of date to Highlight in Preliminary check on the basis of date [Small].Apr 2 2020, 6:32 PM
Niharika triaged this task as Medium priority.

Change 587234 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] PreliminaryCheckPager: Highlight registration results by date

https://gerrit.wikimedia.org/r/587234

Change 587234 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] PreliminaryCheckPager: Highlight registration results by date

https://gerrit.wikimedia.org/r/587234

Same dates are highlighted in the preliminary check table, ignoring time. It can be pinned like other highlighting.

The date is based on the logged in user's timezone, so highlighting might be different for different users (i.e. the date might be different in different timezones).

Tested on Chrome 81 and Safari 12.1.

The date is based on the logged in user's timezone, so highlighting might be different for different users (i.e. the date might be different in different timezones).

@Prtksxna I think we didn't explicitly discuss this. I was assuming dates will be in UTC. Do you think we need to make it explicit that the dates are in the user's timezone?

@Prtksxna I think we didn't explicitly discuss this. I was assuming dates will be in UTC. Do you think we need to make it explicit that the dates are in the user's timezone?

I believe it uses whatever is in the user's preferences: https://test.wikipedia.org/wiki/Special:Preferences#mw-prefsection-rendering

I believe it uses whatever is in the user's preferences: https://test.wikipedia.org/wiki/Special:Preferences#mw-prefsection-rendering

Thanks @dbarratt, this makes sense. It is a generic setting and should be applied everywhere it makes sense.