Page MenuHomePhabricator
Create Task
Maniphest T249258

Call to undefined method WikiPageMessageGroup::getKeys()
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.35.0-wmf.26

message
Call to undefined method WikiPageMessageGroup::getKeys()

Impact

Happening spikily, roughly once every few minutes.

Exports of message groups for offline translation is broken.

Notes

Details

Request ID
XoY1@gpAIIQAAlfSCJUAAABC
Request URL
https://meta.wikimedia.org/w/index.php?title=Special:ExportTranslations&language=eo&group=page-Category%3AInternationalization+templates
Stack Trace
exception.trace
#0 /srv/mediawiki/php-1.35.0-wmf.26/extensions/Translate/specials/SpecialExportTranslations.php(45): SpecialExportTranslations->checkInput()
#1 /srv/mediawiki/php-1.35.0-wmf.26/includes/specialpage/SpecialPage.php(575): SpecialExportTranslations->execute(NULL)
#2 /srv/mediawiki/php-1.35.0-wmf.26/includes/specialpage/SpecialPageFactory.php(618): SpecialPage->run(NULL)
#3 /srv/mediawiki/php-1.35.0-wmf.26/includes/MediaWiki.php(299): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#4 /srv/mediawiki/php-1.35.0-wmf.26/includes/MediaWiki.php(973): MediaWiki->performRequest()
#5 /srv/mediawiki/php-1.35.0-wmf.26/includes/MediaWiki.php(535): MediaWiki->main()
#6 /srv/mediawiki/php-1.35.0-wmf.26/index.php(47): MediaWiki->run()
#7 /srv/mediawiki/w/index.php(3): require(string)
#8 {main}
SubjectRepoBranchLines +/-
Really fix fatals on Special:ExportTranslationsmediawiki/extensions/Translatemaster+10 -7
Revert "Special:ExportTranslations: Disallow exporting huge groups"mediawiki/extensions/Translatemaster+0 -15
MessageGroup: Add getKeys methodmediawiki/extensions/Translatemaster+19 -36
Revert "Special:ExportTranslations: Disallow exporting huge groups"mediawiki/extensions/Translatewmf/1.35.0-wmf.26+0 -15
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasejeenaT247774 1.35.0-wmf.27 deployment blockers
 ResolvedPRODUCTION ERRORNikerabbitT249258 Call to undefined method WikiPageMessageGroup::getKeys()

Event Timeline

Jdforrester-WMF created this task.Apr 2 2020, 7:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2020, 7:02 PM
Jdforrester-WMF moved this task from Untriaged to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.Apr 2 2020, 7:15 PM
Jdforrester-WMF added a subscriber: Nikerabbit.

New in wmf.26.

Happens after:

		// Do not show this error if no/invalid format is specified for translatable
		// page groups as we can show a textarea box containing the translation page text
		// (however it's not currently supported for other groups).
		if ( !$msgGroup instanceof WikiPageMessageGroup
			&& !in_array( $this->format, self::$validFormats )
		) {
			$status->fatal( 'translate-export-invalid-format' );
		}

Looks like this was caused by rETRA7492129cf85b: Special:ExportTranslations: Disallow exporting huge groups – @Nikerabbit, is this working on TWN?

Jdforrester-WMF moved this task from Apr 2019 / 1.33.wmf.25+ to Apr 2020 on the Wikimedia-production-error board.Apr 2 2020, 7:16 PM
Nikerabbit added a comment.Apr 2 2020, 7:31 PM

Yep the issue is also affecting translatewiki.net. I failed to think it would affect production as well. I made a patch for it already: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/585444 - alternatively reverting the patch you mention is also okay.

Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.Apr 2 2020, 7:32 PM
gerritbot added a comment.Apr 2 2020, 7:33 PM

Change 585444 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] MessageGroup: Add getKeys method

https://gerrit.wikimedia.org/r/585444

gerritbot added a project: Patch-For-Review.Apr 2 2020, 7:33 PM
Nikerabbit added a project: Language-Team (Language-2020-Focus-Sprint).Apr 2 2020, 7:33 PM
Nikerabbit moved this task from Priority Backlog to In Review on the Language-Team (Language-2020-Focus-Sprint) board.
Nikerabbit updated the task description. (Show Details)
gerritbot added a comment.Apr 2 2020, 7:38 PM

Change 585583 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Translate@master] Revert "Special:ExportTranslations: Disallow exporting huge groups"

https://gerrit.wikimedia.org/r/585583

gerritbot added a comment.Apr 2 2020, 7:38 PM

Change 585584 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Translate@wmf/1.35.0-wmf.26] Revert "Special:ExportTranslations: Disallow exporting huge groups"

https://gerrit.wikimedia.org/r/585584

Jdforrester-WMF added a parent task: T247774: 1.35.0-wmf.27 deployment blockers.Apr 2 2020, 7:40 PM

I've marked this as a blocker of next week's train.

gerritbot added a comment.Apr 2 2020, 7:50 PM

Change 585584 merged by jenkins-bot:
[mediawiki/extensions/Translate@wmf/1.35.0-wmf.26] Revert "Special:ExportTranslations: Disallow exporting huge groups"

https://gerrit.wikimedia.org/r/585584

Stashbot added a comment.Apr 2 2020, 7:53 PM

Mentioned in SAL (#wikimedia-operations) [2020-04-02T19:53:44Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.26/extensions/Translate/specials/SpecialExportTranslations.php: T249258: Revert 'Special:ExportTranslations: Disallow exporting huge groups' (duration: 00m 59s)

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Apr 2 2020, 8:00 PM
gerritbot added a comment.Apr 3 2020, 6:55 AM

Change 585444 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] MessageGroup: Add getKeys method

https://gerrit.wikimedia.org/r/585444

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.27; 2020-04-07); removed MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Apr 3 2020, 7:00 AM
gerritbot added a comment.Apr 3 2020, 7:07 AM

Change 585583 abandoned by Nikerabbit:
Revert "Special:ExportTranslations: Disallow exporting huge groups"

Reason:
Not needed since https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/ /585444 was merged.

https://gerrit.wikimedia.org/r/585583

Nikerabbit claimed this task.Apr 3 2020, 7:07 AM
Nikerabbit moved this task from In Review to Needs QA on the Language-Team (Language-2020-Focus-Sprint) board.
Maintenance_bot removed a project: Patch-For-Review.Apr 3 2020, 7:10 AM
Nikerabbit closed this task as Resolved.Apr 6 2020, 8:24 AM
Nikerabbit moved this task from Needs QA to Done on the Language-Team (Language-2020-Focus-Sprint) board.

Deployed and tested on translatewiki.net.

Nikerabbit reopened this task as Open.Apr 7 2020, 6:33 AM
gerritbot added a comment.Apr 7 2020, 6:33 AM

Change 586516 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Really fix fatals on Special:ExportTranslations

https://gerrit.wikimedia.org/r/586516

gerritbot added a project: Patch-For-Review.Apr 7 2020, 6:33 AM
gerritbot added a comment.Apr 7 2020, 7:35 AM

Change 586516 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Really fix fatals on Special:ExportTranslations

https://gerrit.wikimedia.org/r/586516

Maintenance_bot removed a project: Patch-For-Review.Apr 7 2020, 8:10 AM
zeljkofilipin triaged this task as Unbreak Now! priority.Apr 7 2020, 11:32 AM
zeljkofilipin subscribed.

Train blockers are UBN.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptApr 7 2020, 11:32 AM
zeljkofilipin unsubscribed.Apr 7 2020, 11:33 AM
Nikerabbit closed this task as Resolved.Apr 7 2020, 12:16 PM

Re-tested.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL