valued) images explicitly
Closed, ResolvedPublicBUG REPORT
Actions

Description

We have this:

The popular tab queue is currently the result is a (pseudo-)random selection from all images with labels awaiting review. It currently does not prioritize assessed images (featured/quality/valued) as originally intended.

We want this:

Explicitly prioritize the assessed images. The short-term way to do this is sort the queue by "suggestion timestamp" (mvs_timestamp in the db) since the assessed images were run through the Machine Vision algorithm first.

In the medium-to-long term, the data model should be updated to include the concept of which pool ("popular" or "uploads") a set of suggestions belongs to.

Screenshots (if possible):

Acceptance Criteria:

The Popular tab shows only Assessed images until that list has been exhausted (>200k files)

COVID-19 Deployment Criteria (see responses below)

Can you roll back this change without lasting impact?
1. A recovery plan is required as this will help identify our capacity for recovering from the failure
2. THIS IS A KEY QUESTION, if you can’t answer it, you shouldn’t deploy

Is specialized knowledge required to support this change in production? If so, are there multiple people with this knowledge?

Is there a way to increase confidence about the correctness of this change?
1. Reviews (Design, Code, etc)
2. Testing coverage (unit tests, integration tests)
3. Manual testing (e.g. Beta, vagrant, docker)

Details

	Subject	Repo	Branch	Lines +/-
	CAT: Return only "assessed" images if no user ID is provided	mediawiki/extensions/MachineVision	master	+19 -6

Customize query in gerrit

Event Timeline

• Ramsey-WMF created this task.Apr 2 2020, 8:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2020, 8:29 PM

Adding Cormac so he knows what's up (note I've actually set this as high priority because it's kind of a big deal)

Implementation notes:

The query to derive images to serve is in Repository::getTitlesWithUnreviewedLabels. If this is a request for "popular" images and not personal uploads (i.e., if $userId is null), add a join to the existing query for machine_vision_suggestion on mvs_mvl_id = mvl_id and select WHERE mvs_timestamp < 20191201000000. (Label suggestions for assessed images were entered in mid-November 2019 but new upload labeling was not enabled until December or later.)

EDIT: I tested the query for performance with the additional join and it's still fast.

I'm willing to take a stab at the "simple" implementation here, but will probably need some code review assistance again. If this ticket needs to be done ASAP then someone more comfortable writing DB queries should probably pick this up. I'll assign to myself tomorrow if no one has claimed it by then.

egardner claimed this task.Apr 2 2020, 9:43 PM

egardner moved this task from Incoming to Doing on the Structured-Data-Backlog (Current Work) board.

egardner removed egardner as the assignee of this task.Apr 2 2020, 9:55 PM

• Charlotte added a project: Wikipedia-Android-App-Backlog.Apr 2 2020, 10:34 PM

• Charlotte moved this task from Needs Triage to Tracking on the Wikipedia-Android-App-Backlog board.

• Charlotte subscribed.

egardner moved this task from Doing to Ready for Development on the Structured-Data-Backlog (Current Work) board.Apr 3 2020, 8:28 PM

Change 585833 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/extensions/MachineVision@master] CAT: Only return "assessed" images if no user ID is provided

https://gerrit.wikimedia.org/r/585833

gerritbot added a project: Patch-For-Review.Apr 3 2020, 10:27 PM

• Mholloway claimed this task.Apr 3 2020, 10:29 PM

• Mholloway added a project: Product-Infrastructure-Team-Backlog-Deprecated (Kanban).

• Mholloway moved this task from To Do to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

COVID-19 Deployment Criteria

Can you roll back this change without lasting impact?
Yes. Recovery plan: revert the change and the feature will revert to the current behavior.

Is specialized knowledge required to support this change in production? If so, are there multiple people with this knowledge?
Yes. I've discussed the change with Anne and Eric.

Is there a way to increase confidence about the correctness of this change?
The patch will be reviewed and tested, and can be verified on Beta Commons and Test Commons for further verification before hitting prod Commons.

• Mholloway updated the task description. (Show Details)Apr 3 2020, 10:34 PM

• Mholloway moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Apr 7 2020, 3:34 PM

Change 585833 merged by jenkins-bot:
[mediawiki/extensions/MachineVision@master] CAT: Return only "assessed" images if no user ID is provided

https://gerrit.wikimedia.org/r/585833

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 7 2020, 4:01 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 7 2020, 4:11 PM

• Ramsey-WMF moved this task from Ready for Development to Verify on Production on the Structured-Data-Backlog (Current Work) board.Apr 8 2020, 7:18 PM

• Mholloway moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Apr 13 2020, 8:03 PM

Done and looking great.