Page MenuHomePhabricator
Create Task
Maniphest T249459

Hard deprecate global function wfIsBadImage and remove a release later
Closed, ResolvedPublic
Actions

Description

wfIsBadImage is unused and could be hard deprecated.

https://codesearch.wmflabs.org/search/?q=wfIsBadImage&i=fosho&files=&repos=

outstanding patch sets for remove deprecated code:
https://gerrit.wikimedia.org/r/#/q/topic:badfilelookup+(status:open+OR+status:merged)

Details

SubjectRepoBranchLines +/-
Remove hard deprecated wfIsBadImage()mediawiki/coremaster+1 -69
Remove usage of hard deprecated function wfIsBadImage()mediawiki/extensions/PhpTagsWidgetsmaster+1 -1
Hard deprecate wfIsBadImage()mediawiki/coremaster+2 -0
Remove default BadImageRemover constructor $isFiltered parametermediawiki/extensions/Flowmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Apr 5 2020, 7:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 5 2020, 7:24 PM
DannyS712 updated the task description. (Show Details)Apr 6 2020, 2:35 AM
DannyS712 mentioned this in T249995: Create #mediawiki-global-scope.Apr 11 2020, 11:21 AM
Reedy subscribed.Jun 8 2020, 11:58 PM

It's not unused. It needs removing from Flow BadImageRemover

gerritbot added a comment.Jun 9 2020, 12:03 AM

Change 603678 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Flow@master] Remove default BadImageRemover constructor $isFiltered parameter

https://gerrit.wikimedia.org/r/603678

gerritbot added a project: Patch-For-Review.Jun 9 2020, 12:03 AM
gerritbot added a comment.Jun 9 2020, 12:08 AM

Change 603679 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Hard deprecate wfIsBadImage()

https://gerrit.wikimedia.org/r/603679

gerritbot added a comment.Jun 9 2020, 2:17 AM

Change 603678 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Remove default BadImageRemover constructor $isFiltered parameter

https://gerrit.wikimedia.org/r/603678

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 9 2020, 3:00 AM
Umherirrender added a comment.Jun 9 2020, 6:24 PM
In T249459#6204338, @Reedy wrote:

It's not unused. It needs removing from Flow BadImageRemover

Flow was changed with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/586134/

Reedy added a comment.Jun 9 2020, 6:26 PM
In T249459#6207256, @Umherirrender wrote:
In T249459#6204338, @Reedy wrote:

It's not unused. It needs removing from Flow BadImageRemover

Flow was changed with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/586134/

It was, but the usage in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/603678/ wasn't

So while it wasn't directly used, if something depending on Flow tried to call it, it could cause it to be used

gerritbot added a comment.Jun 9 2020, 9:50 PM

Change 603679 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate wfIsBadImage()

https://gerrit.wikimedia.org/r/603679

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.37; 2020-06-16); removed MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 9 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 9 2020, 10:10 PM
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.Dec 18 2020, 7:56 PM
DannyS712 subscribed.

Hard deprecated in 1.35, so can be removed now

gerritbot added a comment.Dec 29 2020, 1:44 PM

Change 652402 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/PhpTagsWidgets@master] Remove usage of hard deprecated function wfIsBadImage()

https://gerrit.wikimedia.org/r/652402

gerritbot added a project: Patch-For-Review.Dec 29 2020, 1:44 PM
taavi subscribed.Dec 29 2020, 1:49 PM

I sent patches to mediawiki/extensions/PhpTagsWidgets and https://github.com/oetterer/BootstrapComponents to remove some uses found in codesearch

gerritbot added a comment.Dec 29 2020, 1:52 PM

Change 652403 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/core@master] Remove hard deprecated wfIsBadImage()

https://gerrit.wikimedia.org/r/652403

taavi claimed this task.Dec 29 2020, 1:53 PM
Restricted Application added a project: User-Majavah. · View Herald TranscriptDec 29 2020, 1:53 PM
taavi moved this task from Unsorted to Pending review on the User-Majavah board.Dec 29 2020, 5:30 PM
gerritbot added a comment.Dec 29 2020, 8:59 PM

Change 652402 abandoned by Majavah:
[mediawiki/extensions/PhpTagsWidgets@master] Remove usage of hard deprecated function wfIsBadImage()

Reason:
oops, didn't see that - sorry

https://gerrit.wikimedia.org/r/652402

gerritbot added a comment.Dec 29 2020, 9:24 PM

Change 652403 merged by jenkins-bot:
[mediawiki/core@master] Remove hard deprecated wfIsBadImage()

https://gerrit.wikimedia.org/r/652403

DannyS712 closed this task as Resolved.Dec 29 2020, 9:56 PM
DannyS712 removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 29 2020, 10:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL