Page MenuHomePhabricator

Hard deprecate global function wfIsBadImage and remove a release later
Open, Needs TriagePublic

Description

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 5 2020, 7:24 PM
DannyS712 updated the task description. (Show Details)Apr 6 2020, 2:35 AM
Reedy added a subscriber: Reedy.Jun 8 2020, 11:58 PM

It's not unused. It needs removing from Flow BadImageRemover

Change 603678 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Flow@master] Remove default BadImageRemover constructor $isFiltered parameter

https://gerrit.wikimedia.org/r/603678

Change 603679 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Hard deprecate wfIsBadImage()

https://gerrit.wikimedia.org/r/603679

Change 603678 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Remove default BadImageRemover constructor $isFiltered parameter

https://gerrit.wikimedia.org/r/603678

It's not unused. It needs removing from Flow BadImageRemover

Flow was changed with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/586134/

Reedy added a comment.Jun 9 2020, 6:26 PM

It's not unused. It needs removing from Flow BadImageRemover

Flow was changed with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/586134/

It was, but the usage in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/603678/ wasn't

So while it wasn't directly used, if something depending on Flow tried to call it, it could cause it to be used

Change 603679 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate wfIsBadImage()

https://gerrit.wikimedia.org/r/603679