phan and taint-check weird interactions: PhanUndeclaredThis, part 2
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Daimona
	Apr 6 2020, 4:48 PM

Description

Almost the same as T249491. Examples:

includes/Title.php:1008 PhanUndeclaredThis Variable $this is undeclared
includes/config/ServiceOptions.php:88 PhanUndeclaredThis Variable $this is undeclared
includes/shell/Result.php:76 PhanUndeclaredThis Variable $this is undeclared

Details

	Subject	Repo	Branch	Lines +/-
	Fix bad interaction with phan, part 3	mediawiki/tools/phan/SecurityCheckPlugin	master	+36 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T175865 CentralNotice banner goes behind of global user page's top menu buttons
Declined		None	T254277 Proposal: Stop collapsing Vector menu items under more menu and removal associated code
Resolved		Jdlrobson	T71729 [collapsibleTabs] If a tab's width changes after initial page load, endless animation loop can happen
Resolved	BUG REPORT	ovasileva	T253819 Regression: Dancing Search Bar in MediaWiki when menu is hidden
Resolved		Daimona	T254079 phan-seccheck typeerror
Resolved		Jdforrester-WMF	T248630 Upgrade phan to 0.10.2 and remove phan-taint-check-plugin
Resolved		Daimona	T249519 phan and taint-check weird interactions: PhanUndeclaredThis, part 2

Event Timeline

Daimona created this task.Apr 6 2020, 4:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2020, 4:48 PM

Daimona claimed this task.Apr 6 2020, 4:49 PM

Daimona triaged this task as High priority.

Daimona added a parent task: T248742: Weird interaction between phan and taint-check: PhanUndeclaredVariable.

Daimona edited parent tasks, added: T248630: Upgrade phan to 0.10.2 and remove phan-taint-check-plugin; removed: T248742: Weird interaction between phan and taint-check: PhanUndeclaredVariable.

Jdforrester-WMF subscribed.Apr 6 2020, 5:25 PM

Jdforrester-WMF moved this task from Backlog to Plugin itself on the phan-taint-check-plugin board.Apr 6 2020, 5:49 PM

A bit of investigation: this is very similar to T249491, in that the same code path is involved. This time, the problem is that we try to read the saved data before writing it. Also, the class must be namespaced for the issue to show up.

Change 587238 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/tools/phan/SecurityCheckPlugin@master] Fix bad interaction with phan, part 3

https://gerrit.wikimedia.org/r/587238

gerritbot added a project: Patch-For-Review.Apr 7 2020, 11:58 AM

Daimona mentioned this in T249619: phan and taint-check weird interactions: PhanUndeclaredThis, part 3.Apr 7 2020, 2:13 PM

Change 587238 merged by jenkins-bot:
[mediawiki/tools/phan/SecurityCheckPlugin@master] Fix bad interaction with phan, part 3

https://gerrit.wikimedia.org/r/587238

Daimona closed this task as Resolved.Apr 7 2020, 3:45 PM

Daimona removed a project: Patch-For-Review.

Daimona mentioned this in rMTPSd80d0ccedffb: Fix bad interaction with phan, part 3.Apr 7 2020, 3:49 PM