Page MenuHomePhabricator

reassignEdits.php broken
Closed, ResolvedPublic

Description

It seems reassignEdits.php is broken on REL1_34 (at least, and probably newer) for IPv4 and IPv6 addresses. Suspect Actor migrations stuff?

$ php maintenance/reassignEdits.php 192.168.0.10 username
Checking current edits...found 0.
Checking deleted edits...found 0.
Checking recent changes...found 0.
Total entries to change: 0

Event Timeline

Change 586422 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/core@master] Fix actor support in reassignEdits.php maintenance script

https://gerrit.wikimedia.org/r/586422

Is this patch going to be approved before 1.35 release?

Change 616120 had a related patch set uploaded (by Clarakosi; owner: Daniel Kinzler):
[mediawiki/core@master] reassignEdits: Update script to use User::newFromName for anon users

https://gerrit.wikimedia.org/r/616120

Change 586422 abandoned by Jack Phoenix:
[mediawiki/core@master] Fix actor support in reassignEdits.php maintenance script

Reason:
Glad if a better solution was found and if this patch was of any use in finding said solution. That being said, I'd argue that over 3 months is somewhat of a long time to wait for code review, given that this patch was submitted the same day the Phab ticket was opened. There was a lot of potential here to get the fix merged -- or whipped into shape and then merged -- either during the same day or reasonably quickly.

https://gerrit.wikimedia.org/r/586422

Change 616120 merged by jenkins-bot:
[mediawiki/core@master] reassignEdits: Update script to use User::newFromName for anon users

https://gerrit.wikimedia.org/r/616120

Change 618295 had a related patch set uploaded (by Reedy; owner: Daniel Kinzler):
[mediawiki/core@REL1_35] reassignEdits: Update script to use User::newFromName for anon users

https://gerrit.wikimedia.org/r/618295

Change 618297 had a related patch set uploaded (by Reedy; owner: Daniel Kinzler):
[mediawiki/core@REL1_34] reassignEdits: Update script to use User::newFromName for anon users

https://gerrit.wikimedia.org/r/618297

I've just created a backport of this to REL1_35 and the supporting change...

As the original bug report was against REL1_34, it needs fixing there. UserFactory doesn't exist in 1.34 (new in 1.35), so I've reverted that change from the patch... Is https://gerrit.wikimedia.org/r/c/mediawiki/core/+/618297/2/maintenance/reassignEdits.php sufficient? Or are other changes needed?

Is this also broken in REL1_31 too?

Change 618295 merged by jenkins-bot:
[mediawiki/core@REL1_35] reassignEdits: Update script to use User::newFromName for anon users

https://gerrit.wikimedia.org/r/618295

Change 618297 merged by jenkins-bot:
[mediawiki/core@REL1_34] reassignEdits: Update script to use User::newFromName for anon users

https://gerrit.wikimedia.org/r/618297

All patches merged. Looks like this task can be closed as resolved

Reedy assigned this task to daniel.
Reedy removed a project: Patch-For-Review.