Page MenuHomePhabricator
Create Task
Maniphest T249521

reassignEdits.php broken
Closed, ResolvedPublic
Actions

Description

It seems reassignEdits.php is broken on REL1_34 (at least, and probably newer) for IPv4 and IPv6 addresses. Suspect Actor migrations stuff?

$ php maintenance/reassignEdits.php 192.168.0.10 username
Checking current edits...found 0.
Checking deleted edits...found 0.
Checking recent changes...found 0.
Total entries to change: 0

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
reassignEdits: Update script to use User::newFromName for anon usersmediawiki/coreREL1_34+2 -3
reassignEdits: Update script to use User::newFromName for anon usersmediawiki/coreREL1_35+6 -6
reassignEdits: Update script to use User::newFromName for anon usersmediawiki/coremaster+5 -5
Fix actor support in reassignEdits.php maintenance scriptmediawiki/coremaster+31 -18
Customize query in gerrit

Event Timeline

Reedy created this task.Apr 6 2020, 5:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2020, 5:15 PM
Reedy added a project: MW-1.34-release.Apr 6 2020, 5:15 PM
charitwo subscribed.Apr 6 2020, 5:18 PM
gerritbot added a comment.Apr 6 2020, 7:24 PM

Change 586422 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/core@master] Fix actor support in reassignEdits.php maintenance script

https://gerrit.wikimedia.org/r/586422

gerritbot added a project: Patch-For-Review.Apr 6 2020, 7:24 PM
Anomie edited projects, added: Platform Team Workboards (External Code Reviews); removed: Platform Engineering.Apr 7 2020, 2:21 PM
charitwo added a comment.Jul 19 2020, 8:21 PM

Is this patch going to be approved before 1.35 release?

Aklapper added a project: MW-1.35-release.Jul 20 2020, 8:33 AM
gerritbot added a comment.Jul 24 2020, 5:14 PM

Change 616120 had a related patch set uploaded (by Clarakosi; owner: Daniel Kinzler):
[mediawiki/core@master] reassignEdits: Update script to use User::newFromName for anon users

https://gerrit.wikimedia.org/r/616120

gerritbot added a comment.Aug 3 2020, 2:02 PM

Change 586422 abandoned by Jack Phoenix:
[mediawiki/core@master] Fix actor support in reassignEdits.php maintenance script

Reason:
Glad if a better solution was found and if this patch was of any use in finding said solution. That being said, I'd argue that over 3 months is somewhat of a long time to wait for code review, given that this patch was submitted the same day the Phab ticket was opened. There was a lot of potential here to get the fix merged -- or whipped into shape and then merged -- either during the same day or reasonably quickly.

https://gerrit.wikimedia.org/r/586422

gerritbot added a comment.Aug 3 2020, 6:07 PM

Change 616120 merged by jenkins-bot:
[mediawiki/core@master] reassignEdits: Update script to use User::newFromName for anon users

https://gerrit.wikimedia.org/r/616120

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Aug 3 2020, 7:00 PM
gerritbot added a comment.Aug 4 2020, 2:55 PM

Change 618295 had a related patch set uploaded (by Reedy; owner: Daniel Kinzler):
[mediawiki/core@REL1_35] reassignEdits: Update script to use User::newFromName for anon users

https://gerrit.wikimedia.org/r/618295

gerritbot added a comment.Aug 4 2020, 3:03 PM

Change 618297 had a related patch set uploaded (by Reedy; owner: Daniel Kinzler):
[mediawiki/core@REL1_34] reassignEdits: Update script to use User::newFromName for anon users

https://gerrit.wikimedia.org/r/618297

Reedy added a comment.Aug 4 2020, 3:06 PM

I've just created a backport of this to REL1_35 and the supporting change...

As the original bug report was against REL1_34, it needs fixing there. UserFactory doesn't exist in 1.34 (new in 1.35), so I've reverted that change from the patch... Is https://gerrit.wikimedia.org/r/c/mediawiki/core/+/618297/2/maintenance/reassignEdits.php sufficient? Or are other changes needed?

Is this also broken in REL1_31 too?

gerritbot added a comment.Aug 6 2020, 2:22 PM

Change 618295 merged by jenkins-bot:
[mediawiki/core@REL1_35] reassignEdits: Update script to use User::newFromName for anon users

https://gerrit.wikimedia.org/r/618295

ReleaseTaggerBot added a project: MW-1.35-notes.Aug 6 2020, 3:00 PM
Reedy moved this task from Blocker to Done on the MW-1.35-release board.Aug 14 2020, 2:14 AM
gerritbot added a comment.Sep 8 2020, 2:50 PM

Change 618297 merged by jenkins-bot:
[mediawiki/core@REL1_34] reassignEdits: Update script to use User::newFromName for anon users

https://gerrit.wikimedia.org/r/618297

ReleaseTaggerBot added a project: MW-1.34-notes.Sep 8 2020, 3:00 PM
daniel moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (External Code Reviews) board.Sep 8 2020, 8:22 PM
Ciencia_Al_Poder subscribed.Sep 11 2020, 2:36 PM

All patches merged. Looks like this task can be closed as resolved

Reedy closed this task as Resolved.Sep 20 2020, 11:38 PM
Reedy assigned this task to daniel.
Reedy removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits