Description

Motivation

At the moment code in pool counter isn't exception-safe and therefore the case when PoolCounter isn't released is possible.

Expected Result

PoolCounterWork should cover the case when doWork raises an exception
PoolCounterWork should be covered by tests

Details

	Subject	Repo	Branch	Lines +/-
	poolcounter: Call poolCounter->release on exception and add tests for PoolCounterWork	mediawiki/core	master	+264 -6

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Peter.ovchyn	T243803 API action=parse should be poolcounter-limited if a re-parse is necessary
		Resolved		Peter.ovchyn	T249531 Improve PoolCounterWork logic to cover possible raised exceptions

Event Timeline

Peter.ovchyn created this task.Apr 6 2020, 6:23 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptApr 6 2020, 6:23 PM

Change 587212 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/core@master] poolcounter: Add tests for PoolCounterWork

https://gerrit.wikimedia.org/r/587212

gerritbot added a project: Patch-For-Review.Apr 7 2020, 9:30 AM

daniel triaged this task as Medium priority.Apr 7 2020, 1:01 PM

daniel moved this task from Inbox to Backlog on the Platform Team Workboards (Clinic Duty Team) board.

Anomie moved this task from Backlog to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Apr 7 2020, 1:08 PM

Krinkle moved this task from Active investigation to Follow-up prevention on the Wikimedia-Incident board.Apr 8 2020, 4:42 PM

Change 587212 merged by jenkins-bot:
[mediawiki/core@master] poolcounter: Call poolCounter->release on exception and add tests for PoolCounterWork

https://gerrit.wikimedia.org/r/587212

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 15 2020, 6:00 PM

daniel closed this task as Resolved.Apr 16 2020, 12:14 PM

daniel moved this task from Waiting for Review to Done on the Platform Team Workboards (Clinic Duty Team) board.

Krinkle edited projects, added Sustainability (Incident Followup); removed Wikimedia-Incident.Apr 28 2020, 9:50 PM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM

Stang unsubscribed.Nov 13 2021, 11:58 PM