Page MenuHomePhabricator
Create Task
Maniphest T249556

Structured Data interface does not work on IE11
Closed, ResolvedPublic
Actions

Description

@Nikki reports that the Structured Data on Commons user interface does not work on Internet Explorer 11 – clicking on the “structured data” tab does nothing. In the console, an error appears:

SCRIPT5007: Object.getPrototypeOf: 'this' ist kein Objekt [translation: 'this' is not an object]

I assume this is because, according to MDN,

In ES5, it will throw a TypeError exception if the obj parameter isn't an object. In ES2015, the parameter will be coerced to an Object.

And WikibaseMediaInfo contains code like this:

Object.getPrototypeOf( d[ key ] || '' ) === Object.prototype

which directly relies on Object.getPrototypeOf( '' ) being valid, even though apparently in ES5 it’s not.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikibaseMediaInfomaster+3 -3Use auto flex-basis instead of 0, fixing flexbox issues in IE
mediawiki/extensions/WikibaseMediaInfomaster+1 -1Use jQuery element instead of node
mediawiki/extensions/WikibaseMediaInfomaster+4 -4Fix IE11 incompatibility
Customize query in gerrit

Event Timeline

Restricted Application added a project: Wikidata. · View Herald TranscriptApr 6 2020, 9:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Apr 7 2020, 1:37 PM

Change 587258 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Fix IE11 incompatibility

https://gerrit.wikimedia.org/r/587258

gerritbot added a comment.Apr 8 2020, 10:21 AM

Change 587258 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Fix IE11 incompatibility

https://gerrit.wikimedia.org/r/587258

Ramsey-WMF moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Apr 8 2020, 8:10 PM
Ramsey-WMF added a subscriber: Ramsey-WMF.

should be testable on Beta but you'll need IE11

Ramsey-WMF reassigned this task from matthiasmullie to Etonkovidova.Apr 8 2020, 8:30 PM
Ramsey-WMF added a subscriber: matthiasmullie.
Nikki added a comment.Apr 9 2020, 3:09 PM

I tested it and it's now possible to click the tab, but it still doesn't work properly. The text is a mess (the things which should be right-aligned are on top of the things on the left) and there are errors when trying to edit anything (nothing happens after selecting an item and the "add statement" button doesn't work). Should those be new tickets or should I just add the errors/screenshot here?

Nikki added a comment.Apr 17 2020, 7:00 PM

I'll put them both here for now.

Here's a screenshot of how sections on the structured data tab render:

The error I get when clicking "Add statement" or selecting an item is:

jQuery.Deferred exception: Das Objekt unterstützt die Eigenschaft oder Methode "after" nicht TypeError: Das Objekt unterstützt die Eigenschaft oder Methode "after" nicht
   at Anonymous function (Unknown script code:56:650)
   at ComponentWidget.prototype.rebuildDOM (Unknown script code:56:438)
   at Anonymous function (Unknown script code:57:236)
   at ComponentWidget.prototype.rebuildDOM (Unknown script code:56:438)
   at Anonymous function (Unknown script code:55:963)
   at mightThrow (https://commons.wikimedia.beta.wmflabs.org/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cjquery.ui%7Cwikibase.mediainfo.statements%7Cwikibase.tainted-ref%7Cwikibase.view.ControllerViewFactory&skin=vector&version=zr15n:49:132)
   at Anonymous function (https://commons.wikimedia.beta.wmflabs.org/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cjquery.ui%7Cwikibase.mediainfo.statements%7Cwikibase.tainted-ref%7Cwikibase.view.ControllerViewFactory&skin=vector&version=zr15n:49:808) undefi
[object Error]{description: "Das Objekt ...", message: "Das Objekt ...", name: "TypeError", number: -2146827850, stack: "TypeError: ..."}
Ramsey-WMF reassigned this task from Etonkovidova to matthiasmullie.Apr 17 2020, 7:04 PM
Ramsey-WMF moved this task from Needs QA to Doing on the Structured-Data-Backlog (Current Work) board.
Ramsey-WMF added a subscriber: Etonkovidova.

thanks for the additional test. I'll go ahead and but this back on the radar for the developer.

gerritbot added a comment.May 26 2020, 2:18 PM

Change 598747 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Use jQuery element instead of node

https://gerrit.wikimedia.org/r/598747

gerritbot added a comment.May 28 2020, 7:49 PM

Change 598747 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Use jQuery element instead of node

https://gerrit.wikimedia.org/r/598747

gerritbot added a comment.Jun 10 2020, 7:58 AM

Change 604298 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Use auto flex-basis instead of 0, fixing flexbox issues in IE

https://gerrit.wikimedia.org/r/604298

matthiasmullie added a comment.Jun 10 2020, 8:01 AM

It looks like all JS errors in IE have now been resolved.
There's still display issues, but I've just submitted a patch that should also resolve those.

gerritbot added a comment.Mon, Jun 15, 3:52 PM

Change 604298 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Use auto flex-basis instead of 0, fixing flexbox issues in IE

https://gerrit.wikimedia.org/r/604298

matthiasmullie closed this task as Resolved.Mon, Jun 22, 9:24 AM
matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.

Things work & look fine now on my IE machine!

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL